2022-07-21 16:42:11

by Parikshit Pareek

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device

Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.

Signed-off-by: Parikshit Pareek <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c566276856ad..5729ce19eb16 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -650,6 +650,7 @@ properties:
- items:
- enum:
- qcom,sa8295p-adp
+ - qcom,sa8540p-adp-ride
- const: qcom,sa8540p

- items:
--
2.17.1


2022-07-21 17:03:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device

On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
>
> Signed-off-by: Parikshit Pareek <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-07-21 17:05:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device

On 21/07/2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
>
> Signed-off-by: Parikshit Pareek <[email protected]>

Bindings are always first commit, otherwise your patchset is not bisectable.

Best regards,
Krzysztof

2022-07-21 18:57:26

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: arm: qcom: Document additional sa8540p device



On 21.07.2022 17:44, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
>
> Signed-off-by: Parikshit Pareek <[email protected]>
> ---
The bindings patch should come before the one that introduces code
that's being documented.

Konrad
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index c566276856ad..5729ce19eb16 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -650,6 +650,7 @@ properties:
> - items:
> - enum:
> - qcom,sa8295p-adp
> + - qcom,sa8540p-adp-ride
> - const: qcom,sa8540p
>
> - items: