The functions icu_init_irq and mmp2_init_icu are exported
from this code, so declare them in the header file to avoid
the following sparse warnings:
drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static?
drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?
Signed-off-by: Ben Dooks <[email protected]>
---
include/linux/irqchip/mmp.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/irqchip/mmp.h b/include/linux/irqchip/mmp.h
index cb8455c87c8a..aa1813749a4f 100644
--- a/include/linux/irqchip/mmp.h
+++ b/include/linux/irqchip/mmp.h
@@ -4,4 +4,7 @@
extern struct irq_chip icu_irq_chip;
+extern void icu_init_irq(void);
+extern void mmp2_init_icu(void);
+
#endif /* __IRQCHIP_MMP_H */
--
2.35.1
On Fri, Jul 22, 2022 at 08:41:53AM +0100, Marc Zyngier wrote:
> On Thu, 21 Jul 2022 22:51:47 +0100,
> Ben Dooks <[email protected]> wrote:
> >
> > The functions icu_init_irq and mmp2_init_icu are exported
> > from this code, so declare them in the header file to avoid
> > the following sparse warnings:
> $ git grep -E "icu_init_irq|mmp2_init_icu"
> arch/arm/mach-mmp/mmp2.c: mmp2_init_icu();
> arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
> arch/arm/mach-mmp/pxa168.c: icu_init_irq();
> arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
> arch/arm/mach-mmp/pxa910.c: icu_init_irq();
> arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
> drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
> drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)
>
> If you are going to fix this, please fix it sensibly.
Ok, didn't realise these where not being built my the v7_multi defconfig.
Should this all go into one patch or do the arch/arm bits need to go via
some arm tree?
--
Ben Dooks, [email protected], http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
On Thu, 21 Jul 2022 22:51:47 +0100,
Ben Dooks <[email protected]> wrote:
>
> The functions icu_init_irq and mmp2_init_icu are exported
> from this code, so declare them in the header file to avoid
> the following sparse warnings:
>
> drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static?
> drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <[email protected]>
> ---
> include/linux/irqchip/mmp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/irqchip/mmp.h b/include/linux/irqchip/mmp.h
> index cb8455c87c8a..aa1813749a4f 100644
> --- a/include/linux/irqchip/mmp.h
> +++ b/include/linux/irqchip/mmp.h
> @@ -4,4 +4,7 @@
>
> extern struct irq_chip icu_irq_chip;
>
> +extern void icu_init_irq(void);
> +extern void mmp2_init_icu(void);
> +
> #endif /* __IRQCHIP_MMP_H */
> --
> 2.35.1
>
>
$ git grep -E "icu_init_irq|mmp2_init_icu"
arch/arm/mach-mmp/mmp2.c: mmp2_init_icu();
arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
arch/arm/mach-mmp/pxa168.c: icu_init_irq();
arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
arch/arm/mach-mmp/pxa910.c: icu_init_irq();
arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)
If you are going to fix this, please fix it sensibly.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
On Fri, 22 Jul 2022 09:03:33 +0100,
Ben Dooks <[email protected]> wrote:
>
> On Fri, Jul 22, 2022 at 08:41:53AM +0100, Marc Zyngier wrote:
> > On Thu, 21 Jul 2022 22:51:47 +0100,
> > Ben Dooks <[email protected]> wrote:
> > >
> > > The functions icu_init_irq and mmp2_init_icu are exported
> > > from this code, so declare them in the header file to avoid
> > > the following sparse warnings:
>
> > $ git grep -E "icu_init_irq|mmp2_init_icu"
> > arch/arm/mach-mmp/mmp2.c: mmp2_init_icu();
> > arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void);
> > arch/arm/mach-mmp/pxa168.c: icu_init_irq();
> > arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void);
> > arch/arm/mach-mmp/pxa910.c: icu_init_irq();
> > arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void);
> > drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void)
> > drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void)
> >
> > If you are going to fix this, please fix it sensibly.
>
> Ok, didn't realise these where not being built my the v7_multi defconfig.
> Should this all go into one patch or do the arch/arm bits need to go via
> some arm tree?
One single patch please, which I'll queue directly.
M.
--
Without deviation from the norm, progress is not possible.