2022-07-22 10:52:33

by Slark Xiao

[permalink] [raw]
Subject: [PATCH] s390/qeth: Fix typo 'the the' in comment

Replace 'the the' with 'the' in the comment.

Signed-off-by: Slark Xiao <[email protected]>
---
drivers/s390/net/qeth_core_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index 9e54fe76a9b2..35d4b398c197 100644
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
if (!atomic_read(&queue->set_pci_flags_count)) {
/*
* there's no outstanding PCI any more, so we
- * have to request a PCI to be sure the the PCI
+ * have to request a PCI to be sure the PCI
* will wake at some time in the future then we
* can flush packed buffers that might still be
* hanging around, which can happen if no
--
2.25.1


2022-07-22 11:04:36

by Alexandra Winter

[permalink] [raw]
Subject: Re: [PATCH] s390/qeth: Fix typo 'the the' in comment

On 22.07.22 11:38, Slark Xiao wrote:
> Replace 'the the' with 'the' in the comment.
>
> Signed-off-by: Slark Xiao <[email protected]>
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 9e54fe76a9b2..35d4b398c197 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
> if (!atomic_read(&queue->set_pci_flags_count)) {
> /*
> * there's no outstanding PCI any more, so we
> - * have to request a PCI to be sure the the PCI
> + * have to request a PCI to be sure the PCI
> * will wake at some time in the future then we
> * can flush packed buffers that might still be
> * hanging around, which can happen if no

This trivial typo has been sent twice already to this mailinglist:
https://lore.kernel.org/netdev/Ytb1%[email protected]/T/
https://lore.kernel.org/netdev/[email protected]/t/

2022-07-22 19:07:34

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] s390/qeth: Fix typo 'the the' in comment

On Fri, 22 Jul 2022 12:23:06 +0200 Alexandra Winter wrote:
> On 22.07.22 11:38, Slark Xiao wrote:
> > Replace 'the the' with 'the' in the comment.
> >
> > Signed-off-by: Slark Xiao <[email protected]>
> > ---
> > drivers/s390/net/qeth_core_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> > index 9e54fe76a9b2..35d4b398c197 100644
> > --- a/drivers/s390/net/qeth_core_main.c
> > +++ b/drivers/s390/net/qeth_core_main.c
> > @@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
> > if (!atomic_read(&queue->set_pci_flags_count)) {
> > /*
> > * there's no outstanding PCI any more, so we
> > - * have to request a PCI to be sure the the PCI
> > + * have to request a PCI to be sure the PCI
> > * will wake at some time in the future then we
> > * can flush packed buffers that might still be
> > * hanging around, which can happen if no
>
> This trivial typo has been sent twice already to this mailinglist:
> https://lore.kernel.org/netdev/Ytb1%[email protected]/T/
> https://lore.kernel.org/netdev/[email protected]/t/

Some of the comment spelling fixes get nacked in bulk (e.g. the
previous one was sent with a date of three days prior to the actual
posting). Since they are not in a thread the nacks are hard to see.
Or maybe they got lost 'cause patchwork does not understand
drivers/s390/net is netdev. Anyway, this one looks good, so it will
likely go in.

2022-07-25 02:39:49

by Slark Xiao

[permalink] [raw]
Subject: Re:Re: [PATCH] s390/qeth: Fix typo 'the the' in comment

















At 2022-07-23 02:55:36, "Jakub Kicinski" <[email protected]> wrote:
>On Fri, 22 Jul 2022 12:23:06 +0200 Alexandra Winter wrote:
>> On 22.07.22 11:38, Slark Xiao wrote:
>> > Replace 'the the' with 'the' in the comment.
>> >
>> > Signed-off-by: Slark Xiao <[email protected]>
>> > ---
>> > drivers/s390/net/qeth_core_main.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
>> > index 9e54fe76a9b2..35d4b398c197 100644
>> > --- a/drivers/s390/net/qeth_core_main.c
>> > +++ b/drivers/s390/net/qeth_core_main.c
>> > @@ -3565,7 +3565,7 @@ static void qeth_flush_buffers(struct qeth_qdio_out_q *queue, int index,
>> > if (!atomic_read(&queue->set_pci_flags_count)) {
>> > /*
>> > * there's no outstanding PCI any more, so we
>> > - * have to request a PCI to be sure the the PCI
>> > + * have to request a PCI to be sure the PCI
>> > * will wake at some time in the future then we
>> > * can flush packed buffers that might still be
>> > * hanging around, which can happen if no
>>
>> This trivial typo has been sent twice already to this mailinglist:
>> https://lore.kernel.org/netdev/Ytb1%[email protected]/T/
>> https://lore.kernel.org/netdev/[email protected]/t/
>
>Some of the comment spelling fixes get nacked in bulk (e.g. the
>previous one was sent with a date of three days prior to the actual
>posting). Since they are not in a thread the nacks are hard to see.
>Or maybe they got lost 'cause patchwork does not understand
>drivers/s390/net is netdev. Anyway, this one looks good, so it will
>likely go in.
Yes, I just updated my local linux-next thread. So it's hard to know whether other thread has applied such patches.
It needs time to merge changes between different threads. Especially for some non-fixes commit.

Thanks!

2022-07-25 10:15:13

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] s390/qeth: Fix typo 'the the' in comment

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Fri, 22 Jul 2022 17:38:34 +0800 you wrote:
> Replace 'the the' with 'the' in the comment.
>
> Signed-off-by: Slark Xiao <[email protected]>
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- s390/qeth: Fix typo 'the the' in comment
https://git.kernel.org/netdev/net/c/1aaa62c4838a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html