2022-07-24 06:43:16

by wangjianli

Subject: [PATCH] powerpc/mm: fix repeated words in comments

Delete the redundant word 'so'.

Signed-off-by: wangjianli <[email protected]>
---
arch/powerpc/mm/init-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c
index 119ef491f797..acf5d7ba79d1 100644
--- a/arch/powerpc/mm/init-common.c
+++ b/arch/powerpc/mm/init-common.c
@@ -130,7 +130,7 @@ void pgtable_cache_add(unsigned int shift)

/* It would be nice if this was a BUILD_BUG_ON(), but at the
* moment, gcc doesn't seem to recognize is_power_of_2 as a
- * constant expression, so so much for that. */
+ * constant expression, so much for that. */
BUG_ON(!is_power_of_2(minalign));
BUG_ON(shift > MAX_PGTABLE_INDEX_SIZE);

--
2.36.1

2022-07-25 02:09:14

by Segher Boessenkool

Subject: Re: [PATCH] powerpc/mm: fix repeated words in comments

On Sun, Jul 24, 2022 at 02:36:22PM +0800, wangjianli wrote:
> Delete the redundant word 'so'.

> /* It would be nice if this was a BUILD_BUG_ON(), but at the
> * moment, gcc doesn't seem to recognize is_power_of_2 as a
> - * constant expression, so so much for that. */
> + * constant expression, so much for that. */

It is not redundant here. The first "so" means "therefore", and the
second "so" means "to such a great extent".


Segher