2022-06-29 06:58:16

by XU pengfei

[permalink] [raw]
Subject: [PATCH 1/1] drivers: remove unnecessary (void*) conversions.

remove unnecessary void* type casting.

Signed-off-by: XU pengfei <[email protected]>
---
drivers/i2c/busses/i2c-img-scb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 8e987945ed45..d72211cfda03 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -913,7 +913,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c,

static irqreturn_t img_i2c_isr(int irq, void *dev_id)
{
- struct img_i2c *i2c = (struct img_i2c *)dev_id;
+ struct img_i2c *i2c = dev_id;
u32 int_status, line_status;
/* We handle transaction completion AFTER accessing registers */
unsigned int hret;
--
2.18.2


2022-07-24 05:48:07

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 1/1] drivers: remove unnecessary (void*) conversions.

On Wed, Jun 29, 2022 at 02:09:52PM +0800, XU pengfei wrote:
> remove unnecessary void* type casting.
>
> Signed-off-by: XU pengfei <[email protected]>

Correct, but $subject really needs to contain the subsystem and the
driver. "drivers:" is way too generic. Check 'git log' to see how
subsystems prefer their $subjects.

Attachments:
(No filename) (337.00 B)
 signature.asc (849.00 B)
 Download all attachments

2022-07-25 01:58:00

by XU pengfei

[permalink] [raw]
Subject: [PATCH v2] i2c/busses/drivers/img: remove unnecessary (void*) conversions.

remove unnecessary void* type casting.

Signed-off-by: XU pengfei <[email protected]>
---
drivers/i2c/busses/i2c-img-scb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 8e987945ed45..d72211cfda03 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -913,7 +913,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c,

static irqreturn_t img_i2c_isr(int irq, void *dev_id)
{
- struct img_i2c *i2c = (struct img_i2c *)dev_id;
+ struct img_i2c *i2c = dev_id;
u32 int_status, line_status;
/* We handle transaction completion AFTER accessing registers */
unsigned int hret;
--
2.18.2