2022-07-25 02:41:00

by Ren Zhijie

Subject: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function

If CONFIG_PM_SLEEP is not set,
make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:

sound/pci/hda/cs35l41_hda.c:583:12: error: ‘cs35l41_runtime_resume’ defined but not used [-Werror=unused-function]
static int cs35l41_runtime_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~~
sound/pci/hda/cs35l41_hda.c:565:12: error: ‘cs35l41_runtime_suspend’ defined but not used [-Werror=unused-function]
static int cs35l41_runtime_suspend(struct device *dev)
^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1

commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.

Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
Signed-off-by: Ren Zhijie <[email protected]>
---
sound/pci/hda/cs35l41_hda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index 28798d5c1cf1..93cf039abb02 100644
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -1439,7 +1439,7 @@ void cs35l41_hda_remove(struct device *dev)
EXPORT_SYMBOL_NS_GPL(cs35l41_hda_remove, SND_HDA_SCODEC_CS35L41);

const struct dev_pm_ops cs35l41_hda_pm_ops = {
- SET_RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume, NULL)
+ RUNTIME_PM_OPS(cs35l41_runtime_suspend, cs35l41_runtime_resume, NULL)
};
EXPORT_SYMBOL_NS_GPL(cs35l41_hda_pm_ops, SND_HDA_SCODEC_CS35L41);

--
2.17.1

2022-07-25 06:54:02

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: hda: cs35l41: Fix build error unused-function

On Mon, 25 Jul 2022 04:36:11 +0200,
Ren Zhijie wrote:
>
> If CONFIG_PM_SLEEP is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
>
> sound/pci/hda/cs35l41_hda.c:583:12: error: ?cs35l41_runtime_resume? defined but not used [-Werror=unused-function]
> static int cs35l41_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~
> sound/pci/hda/cs35l41_hda.c:565:12: error: ?cs35l41_runtime_suspend? defined but not used [-Werror=unused-function]
> static int cs35l41_runtime_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [sound/pci/hda/cs35l41_hda.o] Error 1
>
> commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros,
> deprecate old ones"), add new marco RUNTIME_PM_OPS to fix this unused-function problem.
>
> Fixes: 1873ebd30cc8 ("ALSA: hda: cs35l41: Support Hibernation during Suspend")
> Signed-off-by: Ren Zhijie <[email protected]>

Thanks, applied.


Takashi