2022-07-22 14:31:21

by Parikshit Pareek

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: arm: qcom: Document additional sa8540p device

Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.

Signed-off-by: Parikshit Pareek <[email protected]>
---

Changes since v1:
- Make dt-binding patch as the first one in the patch set
- Add , after year 2022, in the license header

Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c566276856ad..5729ce19eb16 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -650,6 +650,7 @@ properties:
- items:
- enum:
- qcom,sa8295p-adp
+ - qcom,sa8540p-adp-ride
- const: qcom,sa8540p

- items:
--
2.17.1


2022-07-22 18:41:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: qcom: Document additional sa8540p device

On 22/07/2022 16:25, Parikshit Pareek wrote:
> Add the ADP ride device to the valid device compatibles found on the
> sa8540p platform.
>
> Signed-off-by: Parikshit Pareek <[email protected]>

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Additionally - please thread your patchset. Git send-email does it by
default. If you use other tools - be sure the effect is threaded.
Otherwise it is not possible to find the patches from you.


Best regards,
Krzysztof

2022-07-25 09:53:18

by Parikshit Pareek

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: qcom: Document additional sa8540p device

On Fri, Jul 22, 2022 at 08:27:39PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2022 16:25, Parikshit Pareek wrote:
> > Add the ADP ride device to the valid device compatibles found on the
> > sa8540p platform.
> >
> > Signed-off-by: Parikshit Pareek <[email protected]>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
My mistake, I missed the tags.
>
>
> Additionally - please thread your patchset. Git send-email does it by
> default. If you use other tools - be sure the effect is threaded.
Used git send-email. May be happened due to the change in one of the commit headers in one of the patches.
> Otherwise it is not possible to find the patches from you.
>
>
> Best regards,
> Krzysztof
Regards,
Parikshit Pareek