2022-07-25 21:27:42

by Ben Dooks

Subject: [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number

Add snps,pwm-number property to indicate if the block does not have
all 8 of the PWM blocks.

Not sure if this should be a general PWM property consider optional
for all PWM types, so have added a specific one here (there is only
one other controller with a property for PWM count at the moment)

Signed-off-by: Ben Dooks <[email protected]>
---
Documentation/devicetree/bindings/pwm/snps,pwm.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
index 594085e5e26f..e95f518b3974 100644
--- a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
@@ -30,11 +30,16 @@ properties:
- const: bus
- const: timer

+ snps,pwm-number:
+ $ref: '/schemas/types.yaml#/definitions/uint32'
+ description: u32 value representing the number of PWM devices
+
required:
- "#pwm-cells"
- compatible
- reg
- clocks
- clock-names
+ - snps,pwm-number

additionalProperties: false
--
2.35.1

2022-07-26 10:24:38

by Ben Dooks

Subject: Re: [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number

On 26/07/2022 11:08, Krzysztof Kozlowski wrote:
> On 25/07/2022 23:21, Ben Dooks wrote:
>> Add snps,pwm-number property to indicate if the block does not have
>> all 8 of the PWM blocks.
>>
>> Not sure if this should be a general PWM property consider optional
>> for all PWM types, so have added a specific one here (there is only
>> one other controller with a property for PWM count at the moment)
>>
>> Signed-off-by: Ben Dooks <[email protected]>
>> ---
>> Documentation/devicetree/bindings/pwm/snps,pwm.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>> index 594085e5e26f..e95f518b3974 100644
>> --- a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
>> @@ -30,11 +30,16 @@ properties:
>> - const: bus
>> - const: timer
>>
>> + snps,pwm-number:
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>
> 1. No quotes
> 2. Add minimum and maximum (it looks like there are such).
>
>> + description: u32 value representing the number of PWM devices
>

ok, thanks.

2022-07-26 10:48:06

by Krzysztof Kozlowski

Subject: Re: [[PATCH v2] 2/9] dt-bindings: pwm: snps,pwm add pwm number

On 25/07/2022 23:21, Ben Dooks wrote:
> Add snps,pwm-number property to indicate if the block does not have
> all 8 of the PWM blocks.
>
> Not sure if this should be a general PWM property consider optional
> for all PWM types, so have added a specific one here (there is only
> one other controller with a property for PWM count at the moment)
>
> Signed-off-by: Ben Dooks <[email protected]>
> ---
> Documentation/devicetree/bindings/pwm/snps,pwm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> index 594085e5e26f..e95f518b3974 100644
> --- a/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/snps,pwm.yaml
> @@ -30,11 +30,16 @@ properties:
> - const: bus
> - const: timer
>
> + snps,pwm-number:
> + $ref: '/schemas/types.yaml#/definitions/uint32'

1. No quotes
2. Add minimum and maximum (it looks like there are such).

> + description: u32 value representing the number of PWM devices


Best regards,
Krzysztof