Add an devicetree bindings for Samsung secure monitor call service.
This driver is used for SoCs produced by Samsung Foundry to provide
SMC call. This patch supports register read/write request to secure
monitor. Also, SMC call request which uses shared memory to exchange
the data between kernel and secure monitor.
Signed-off-by: Dongjin Yang <[email protected]>
---
.../bindings/firmware/samsung,smccc-svc.yaml | 31 ++++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
diff --git a/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
new file mode 100644
index 000000000000..427c42a6cd75
--- /dev/null
+++ b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
@@ -0,0 +1,31 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/firmware/samsung,smccc-svc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Secure Monitor call service
+
+maintainers:
+ - Jesper Nilsson <[email protected]>
+
+description: |
+ The file documents device tree bindings of Samsung secure monitor
+ call service.
+
+properties:
+ compatible:
+ const: samsung,smccc-svc
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+
+ samsung-svc {
+ compatible = "samsung,smccc-svc";
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 20133dcd8ce9..6763746c349f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1862,6 +1862,7 @@ M: Jesper Nilsson <[email protected]>
M: Lars Persson <[email protected]>
L: [email protected]
S: Maintained
+F: Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
F: Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt
F: arch/arm/boot/dts/artpec6*
F: arch/arm/mach-artpec
--
2.9.5
On 13/07/2022 06:53, Dongjin Yang wrote:
> Add an devicetree bindings for Samsung secure monitor call service.
> This driver is used for SoCs produced by Samsung Foundry to provide
> SMC call. This patch supports register read/write request to secure
> monitor. Also, SMC call request which uses shared memory to exchange
> the data between kernel and secure monitor.
>
> Signed-off-by: Dongjin Yang <[email protected]>
> ---
> .../bindings/firmware/samsung,smccc-svc.yaml | 31 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
>
> diff --git a/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
> new file mode 100644
> index 000000000000..427c42a6cd75
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/firmware/samsung,smccc-svc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Secure Monitor call service
> +
> +maintainers:
> + - Jesper Nilsson <[email protected]>
> +
> +description: |
> + The file documents device tree bindings of Samsung secure monitor
> + call service.
> +
> +properties:
> + compatible:
Please add SoC comaptible followed by generic samsung,smccc-svc (so you
need items with an enum and const).
> + const: samsung,smccc-svc
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
No need for blank line.
> + samsung-svc {
Generic node names, e.g. smc.
> + compatible = "samsung,smccc-svc";
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 20133dcd8ce9..6763746c349f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1862,6 +1862,7 @@ M: Jesper Nilsson <[email protected]>
> M: Lars Persson <[email protected]>
> L: [email protected]
> S: Maintained
> +F: Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
Does not look related to Artpec. Shouldn't this be under Samsung Exynos?
> F: Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt
> F: arch/arm/boot/dts/artpec6*
> F: arch/arm/mach-artpec
Best regards,
Krzysztof
Sorry for late response.
On 14/07/2022 04:28, Krzysztof Kozlowski wrote:
> On 13/07/2022 06:53, Dongjin Yang wrote:
> > Add an devicetree bindings for Samsung secure monitor call service.
> > This driver is used for SoCs produced by Samsung Foundry to provide
> > SMC call. This patch supports register read/write request to secure
> > monitor. Also, SMC call request which uses shared memory to exchange
> > the data between kernel and secure monitor.
> >
> > Signed-off-by: Dongjin Yang <[email protected]>
> > ---
> > .../bindings/firmware/samsung,smccc-svc.yaml | 31 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 32 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
> > new file mode 100644
> > index 000000000000..427c42a6cd75
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
> > @@ -0,0 +1,31 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: https://protect2.fireeye.com/v1/url?k=c747301e-a63ad862-c746bb51-74fe485cc33c-a6f2ff257e059cb8&q=1&e=90225601-1202-479c-b95c-fc00645c40ab&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Ffirmware%2Fsamsung%2Csmccc-svc.yaml%23
> > +$schema: https://protect2.fireeye.com/v1/url?k=ec4217dc-8d3fffa0-ec439c93-74fe485cc33c-3c5eca7d394c9eea&q=1&e=90225601-1202-479c-b95c-fc00645c40ab&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
> > +
> > +title: Samsung Secure Monitor call service
> > +
> > +maintainers:
> > + - Jesper Nilsson <[email protected]>
> > +
> > +description: |
> > + The file documents device tree bindings of Samsung secure monitor
> > + call service.
> > +
> > +properties:
> > + compatible:
>
> Please add SoC comaptible followed by generic samsung,smccc-svc (so you
> need items with an enum and const).
>
This patch is for artpec8 soc product. I will add that.
> > + const: samsung,smccc-svc
> > +
> > +required:
> > + - compatible
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +
>
> No need for blank line.
>
> > + samsung-svc {
>
> Generic node names, e.g. smc.
>
> > + compatible = "samsung,smccc-svc";
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 20133dcd8ce9..6763746c349f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1862,6 +1862,7 @@ M: Jesper Nilsson <[email protected]>
> > M: Lars Persson <[email protected]>
> > L: [email protected]
> > S: Maintained
> > +F: Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml
>
> Does not look related to Artpec. Shouldn't this be under Samsung Exynos?
This patch is for artpec8 soc.
>
> > F: Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt
> > F: arch/arm/boot/dts/artpec6*
> > F: arch/arm/mach-artpec
>
>
> Best regards,
> Krzysztof