2022-07-26 14:04:14

by Balsam CHIHI

[permalink] [raw]
Subject: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195

This adds the efuse node. This will be required by the thermal driver
to get the calibration data.

Signed-off-by: Alexandre Bailon <[email protected]>
Signed-off-by: Balsam CHIHI <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index 0ff34edcf8c8..4fbf24b5d202 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
status = "disabled";
};

+ efuse: efuse@11c10000 {
+ compatible = "mediatek,efuse";
+ reg = <0 0x11c10000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ lvts_efuse_data1: lvts1-calib@1bc {
+ reg = <0x1bc 0x14>;
+ };
+ lvts_efuse_data2: lvts2-calib@1d0 {
+ reg = <0x1d0 0x38>;
+ };
+ svs_calibration: calib@580 {
+ reg = <0x580 0x64>;
+ };
+ };
+
u3phy2: t-phy@11c40000 {
compatible = "mediatek,mt8195-tphy", "mediatek,generic-tphy-v3";
#address-cells = <1>;
--
2.34.1


2022-07-29 20:43:00

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195

On Tue, Jul 26, 2022 at 03:55:05PM +0200, Balsam CHIHI wrote:
> This adds the efuse node. This will be required by the thermal driver
> to get the calibration data.
>
> Signed-off-by: Alexandre Bailon <[email protected]>
> Signed-off-by: Balsam CHIHI <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 0ff34edcf8c8..4fbf24b5d202 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
> status = "disabled";
> };
>
> + efuse: efuse@11c10000 {
> + compatible = "mediatek,efuse";
> + reg = <0 0x11c10000 0 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + lvts_efuse_data1: lvts1-calib@1bc {
> + reg = <0x1bc 0x14>;
> + };
> + lvts_efuse_data2: lvts2-calib@1d0 {
> + reg = <0x1d0 0x38>;
> + };
> + svs_calibration: calib@580 {
> + reg = <0x580 0x64>;
> + };
> + };
> +

This commit doesn't apply, there's already an efuse node on mt8195.dtsi. Please
rebase.

Thanks,
N?colas

2022-08-01 13:14:57

by Balsam CHIHI

[permalink] [raw]
Subject: Re: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195

On Fri, Jul 29, 2022 at 10:14 PM Nícolas F. R. A. Prado
<[email protected]> wrote:
>
> On Tue, Jul 26, 2022 at 03:55:05PM +0200, Balsam CHIHI wrote:
> > This adds the efuse node. This will be required by the thermal driver
> > to get the calibration data.
> >
> > Signed-off-by: Alexandre Bailon <[email protected]>
> > Signed-off-by: Balsam CHIHI <[email protected]>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > index 0ff34edcf8c8..4fbf24b5d202 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > @@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
> > status = "disabled";
> > };
> >
> > + efuse: efuse@11c10000 {
> > + compatible = "mediatek,efuse";
> > + reg = <0 0x11c10000 0 0x1000>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + lvts_efuse_data1: lvts1-calib@1bc {
> > + reg = <0x1bc 0x14>;
> > + };
> > + lvts_efuse_data2: lvts2-calib@1d0 {
> > + reg = <0x1d0 0x38>;
> > + };
> > + svs_calibration: calib@580 {
> > + reg = <0x580 0x64>;
> > + };
> > + };
> > +
>
> This commit doesn't apply, there's already an efuse node on mt8195.dtsi. Please
> rebase.
>
> Thanks,
> Nícolas

Hello Nícolas,

Thank you so much for the review.
I rebased on top of the latest kernel version "linux-5.19.0" but I
can't find efuse node on mt8195.dtsi.
But, this node is indeed present on mt8192.dtsi.

Best regards,
Balsam

2022-08-01 14:58:27

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v8 5/6] arm64: dts: mt8195: Add efuse node to mt8195

On Mon, Aug 01, 2022 at 02:33:31PM +0200, Balsam CHIHI wrote:
> On Fri, Jul 29, 2022 at 10:14 PM N?colas F. R. A. Prado
> <[email protected]> wrote:
> >
> > On Tue, Jul 26, 2022 at 03:55:05PM +0200, Balsam CHIHI wrote:
> > > This adds the efuse node. This will be required by the thermal driver
> > > to get the calibration data.
> > >
> > > Signed-off-by: Alexandre Bailon <[email protected]>
> > > Signed-off-by: Balsam CHIHI <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > > index 0ff34edcf8c8..4fbf24b5d202 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> > > @@ -1236,6 +1236,22 @@ nor_flash: spi@1132c000 {
> > > status = "disabled";
> > > };
> > >
> > > + efuse: efuse@11c10000 {
> > > + compatible = "mediatek,efuse";
> > > + reg = <0 0x11c10000 0 0x1000>;
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > + lvts_efuse_data1: lvts1-calib@1bc {
> > > + reg = <0x1bc 0x14>;
> > > + };
> > > + lvts_efuse_data2: lvts2-calib@1d0 {
> > > + reg = <0x1d0 0x38>;
> > > + };
> > > + svs_calibration: calib@580 {
> > > + reg = <0x580 0x64>;
> > > + };
> > > + };
> > > +
> >
> > This commit doesn't apply, there's already an efuse node on mt8195.dtsi. Please
> > rebase.
> >
> > Thanks,
> > N?colas
>
> Hello N?colas,
>
> Thank you so much for the review.
> I rebased on top of the latest kernel version "linux-5.19.0" but I
> can't find efuse node on mt8195.dtsi.
> But, this node is indeed present on mt8192.dtsi.

Hi Balsam,

no I'm really talking about mt8195. For the dts patches in the series you should
base on top of Matthias' -next/dts64 branch [1]. And there you can see the efuse
node on mt8195 [2].

Thanks,
N?colas

[1] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/log/?h=v5.19-next/dts64
[2] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.19-next/dts64&id=ab43a84c9863b65dc20373d5aca4e4d012aa852e