2022-07-27 20:03:21

by Joe Simmons-Talbott

Subject: [PATCH 0/2] iio: Whitespace cleanup

Fix whitespace warnings reported by checkpatch.pl.

Joe Simmons-Talbott (2):
iio: Add blank lines after declarations.
iio: Fix indentation for multiline conditional.

drivers/iio/industrialio-buffer.c | 5 +++--
drivers/iio/industrialio-core.c | 7 +++++++
drivers/iio/industrialio-trigger.c | 1 +
3 files changed, 11 insertions(+), 2 deletions(-)

--
2.36.1

2022-07-27 20:03:35

by Joe Simmons-Talbott

Subject: [PATCH 1/2] iio: Add blank lines after declarations.

As reported by checkpatch.pl add blank lines after declarations.

Signed-off-by: Joe Simmons-Talbott <[email protected]>
---
drivers/iio/industrialio-buffer.c | 1 +
drivers/iio/industrialio-core.c | 7 +++++++
drivers/iio/industrialio-trigger.c | 1 +
3 files changed, 9 insertions(+)

diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index acc2b6c05d57..47a6e97f8e48 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -940,6 +940,7 @@ struct iio_demux_table {
static void iio_buffer_demux_free(struct iio_buffer *buffer)
{
struct iio_demux_table *p, *q;
+
list_for_each_entry_safe(p, q, &buffer->demux_list, l) {
list_del(&p->l);
kfree(p);
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 0f4dbda3b9d3..40ebc63b7919 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -236,6 +236,7 @@ static int iio_sysfs_match_string_with_gaps(const char * const *array, size_t n,
struct dentry *iio_get_debugfs_dentry(struct iio_dev *indio_dev)
{
struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
+
return iio_dev_opaque->debugfs_dentry;
}
EXPORT_SYMBOL_GPL(iio_get_debugfs_dentry);
@@ -447,6 +448,7 @@ static const struct file_operations iio_debugfs_reg_fops = {
static void iio_device_unregister_debugfs(struct iio_dev *indio_dev)
{
struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
+
debugfs_remove_recursive(iio_dev_opaque->debugfs_dentry);
}

@@ -1021,6 +1023,7 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
int ret = 0;
char *name = NULL;
char *full_postfix;
+
sysfs_attr_init(&dev_attr->attr);

/* Build up postfix of <extend_name>_<modifier>_postfix */
@@ -1355,6 +1358,7 @@ static int iio_device_add_channel_sysfs(struct iio_dev *indio_dev,

if (chan->ext_info) {
unsigned int i = 0;
+
for (ext_info = chan->ext_info; ext_info->name; ext_info++) {
ret = __iio_add_chan_devattr(ext_info->name,
chan,
@@ -1403,6 +1407,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
+
return sysfs_emit(buf, "%s\n", indio_dev->name);
}

@@ -1412,6 +1417,7 @@ static ssize_t label_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
+
return sysfs_emit(buf, "%s\n", indio_dev->label);
}

@@ -1777,6 +1783,7 @@ static int iio_chrdev_release(struct inode *inode, struct file *filp)
struct iio_dev_opaque *iio_dev_opaque =
container_of(inode->i_cdev, struct iio_dev_opaque, chrdev);
struct iio_dev *indio_dev = &iio_dev_opaque->indio_dev;
+
kfree(ib);
clear_bit(IIO_BUSY_BIT_POS, &iio_dev_opaque->flags);
iio_device_put(indio_dev);
diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
index b78814d869b7..6885a186fe27 100644
--- a/drivers/iio/industrialio-trigger.c
+++ b/drivers/iio/industrialio-trigger.c
@@ -50,6 +50,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
char *buf)
{
struct iio_trigger *trig = to_iio_trigger(dev);
+
return sysfs_emit(buf, "%s\n", trig->name);
}

--
2.36.1

2022-07-31 12:23:28

by Jonathan Cameron

Subject: Re: [PATCH 0/2] iio: Whitespace cleanup

On Wed, 27 Jul 2022 14:18:53 -0400
Joe Simmons-Talbott <[email protected]> wrote:

> Fix whitespace warnings reported by checkpatch.pl.
Hi Joe,

Series applied to the togreg branch of iio.git and pushed
out as testing. Note I'll rebase that branch on rc1 once
available and not push out as togreg until after that.

Thanks,

Jonathan

>
> Joe Simmons-Talbott (2):
> iio: Add blank lines after declarations.
> iio: Fix indentation for multiline conditional.
>
> drivers/iio/industrialio-buffer.c | 5 +++--
> drivers/iio/industrialio-core.c | 7 +++++++
> drivers/iio/industrialio-trigger.c | 1 +
> 3 files changed, 11 insertions(+), 2 deletions(-)
>