The header file slab.h is unneeded now. Remove it.
Signed-off-by: Miaohe Lin <[email protected]>
---
mm/hugetlb_cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
index d16eb00c947d..99e9a367e1e5 100644
--- a/mm/hugetlb_cgroup.c
+++ b/mm/hugetlb_cgroup.c
@@ -19,7 +19,6 @@
#include <linux/cgroup.h>
#include <linux/page_counter.h>
-#include <linux/slab.h>
#include <linux/hugetlb.h>
#include <linux/hugetlb_cgroup.h>
--
2.23.0
On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <[email protected]> wrote:
>
> The header file slab.h is unneeded now. Remove it.
>
> Signed-off-by: Miaohe Lin <[email protected]>
Acked-by: Mina Almasry <[email protected]>
> ---
> mm/hugetlb_cgroup.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index d16eb00c947d..99e9a367e1e5 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -19,7 +19,6 @@
>
> #include <linux/cgroup.h>
> #include <linux/page_counter.h>
> -#include <linux/slab.h>
> #include <linux/hugetlb.h>
> #include <linux/hugetlb_cgroup.h>
>
> --
> 2.23.0
>
On Thu, Jul 28, 2022 at 10:45 AM Mina Almasry <[email protected]> wrote:
>
> On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <[email protected]> wrote:
> >
> > The header file slab.h is unneeded now. Remove it.
> >
> > Signed-off-by: Miaohe Lin <[email protected]>
>
> Acked-by: Mina Almasry <[email protected]>
>
Actually, sorry, but this file calls kzalloc_node() which comes from
linux/slab.h, no? Can we keep the include then? slab.h is probably
included by other include files but for clarity it's better that
hugetlb_cgroup.c to include slab.h if it is calling functions declared
there.
> > ---
> > mm/hugetlb_cgroup.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> > index d16eb00c947d..99e9a367e1e5 100644
> > --- a/mm/hugetlb_cgroup.c
> > +++ b/mm/hugetlb_cgroup.c
> > @@ -19,7 +19,6 @@
> >
> > #include <linux/cgroup.h>
> > #include <linux/page_counter.h>
> > -#include <linux/slab.h>
> > #include <linux/hugetlb.h>
> > #include <linux/hugetlb_cgroup.h>
> >
> > --
> > 2.23.0
> >
On 2022/7/29 2:02, Mina Almasry wrote:
> On Thu, Jul 28, 2022 at 10:45 AM Mina Almasry <[email protected]> wrote:
>>
>> On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <[email protected]> wrote:
>>>
>>> The header file slab.h is unneeded now. Remove it.
>>>
>>> Signed-off-by: Miaohe Lin <[email protected]>
>>
>> Acked-by: Mina Almasry <[email protected]>
>>
>
> Actually, sorry, but this file calls kzalloc_node() which comes from
> linux/slab.h, no? Can we keep the include then? slab.h is probably
> included by other include files but for clarity it's better that
> hugetlb_cgroup.c to include slab.h if it is calling functions declared
> there.
I have browsed the code to verify it but I still missed kzalloc_node in this file.
Will drop this patch. Many thanks for your review.
>
>>> ---
>>> mm/hugetlb_cgroup.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
>>> index d16eb00c947d..99e9a367e1e5 100644
>>> --- a/mm/hugetlb_cgroup.c
>>> +++ b/mm/hugetlb_cgroup.c
>>> @@ -19,7 +19,6 @@
>>>
>>> #include <linux/cgroup.h>
>>> #include <linux/page_counter.h>
>>> -#include <linux/slab.h>
>>> #include <linux/hugetlb.h>
>>> #include <linux/hugetlb_cgroup.h>
>>>
>>> --
>>> 2.23.0
>>>
> .
>