2022-07-31 07:05:09

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] can: can327: Fix a broken link to Documentation

Since commit 482a4360c56a ("docs: networking: convert netdevices.txt to
ReST"), Documentation/networking/netdevices.txt has been replaced by
Documentation/networking/netdevices.rst.

Update the comment accordingly to avoid a 'make htmldocs' warning

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/net/can/can327.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/can327.c b/drivers/net/can/can327.c
index 5da7778d92dc..925e880bf570 100644
--- a/drivers/net/can/can327.c
+++ b/drivers/net/can/can327.c
@@ -827,7 +827,7 @@ static netdev_tx_t can327_netdev_start_xmit(struct sk_buff *skb,
netif_stop_queue(dev);

/* BHs are already disabled, so no spin_lock_bh().
- * See Documentation/networking/netdevices.txt
+ * See Documentation/networking/netdevices.rst
*/
spin_lock(&elm->lock);
can327_send_frame(elm, frame);
--
2.34.1



2022-07-31 08:57:12

by Max Staudt

[permalink] [raw]
Subject: Re: [PATCH] can: can327: Fix a broken link to Documentation

Thanks, Christophe!

Max




On Sun, 31 Jul 2022 08:32:52 +0200
Christophe JAILLET <[email protected]> wrote:

> Since commit 482a4360c56a ("docs: networking: convert netdevices.txt to
> ReST"), Documentation/networking/netdevices.txt has been replaced by
> Documentation/networking/netdevices.rst.
>
> Update the comment accordingly to avoid a 'make htmldocs' warning
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/net/can/can327.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/can327.c b/drivers/net/can/can327.c
> index 5da7778d92dc..925e880bf570 100644
> --- a/drivers/net/can/can327.c
> +++ b/drivers/net/can/can327.c
> @@ -827,7 +827,7 @@ static netdev_tx_t can327_netdev_start_xmit(struct sk_buff *skb,
> netif_stop_queue(dev);
>
> /* BHs are already disabled, so no spin_lock_bh().
> - * See Documentation/networking/netdevices.txt
> + * See Documentation/networking/netdevices.rst
> */
> spin_lock(&elm->lock);
> can327_send_frame(elm, frame);


2022-07-31 18:56:02

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] can: can327: Fix a broken link to Documentation

On 31.07.2022 10:44:52, Max Staudt wrote:
> Thanks, Christophe!

If you think the patch is Ok, you can give an Acked-by: which is then
recorded in the patch while applying it to the kernel.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachments:
(No filename) (474.00 B)
 signature.asc (499.00 B)
 Download all attachments

2022-07-31 19:04:58

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH] can: can327: Fix a broken link to Documentation

On 31.07.2022 08:32:52, Christophe JAILLET wrote:
> Since commit 482a4360c56a ("docs: networking: convert netdevices.txt to
> ReST"), Documentation/networking/netdevices.txt has been replaced by
> Documentation/networking/netdevices.rst.
>
> Update the comment accordingly to avoid a 'make htmldocs' warning
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Applied to linux-can-next/master.

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachments:
(No filename) (713.00 B)
 signature.asc (499.00 B)
 Download all attachments