2022-07-31 16:06:50

by Joe Simmons-Talbott

Subject: [PATCH] iio: Add names for function definition arguments.

As reported by checkpatch.pl add missing names for function definition
arguments.

Signed-off-by: Joe Simmons-Talbott <[email protected]>
---
drivers/iio/industrialio-event.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
index b5e059e15b0a..0e2056894965 100644
--- a/drivers/iio/industrialio-event.c
+++ b/drivers/iio/industrialio-event.c
@@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
enum iio_shared_by shared_by, const unsigned long *mask)
{
struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
- ssize_t (*show)(struct device *, struct device_attribute *, char *);
- ssize_t (*store)(struct device *, struct device_attribute *,
- const char *, size_t);
+ ssize_t (*show)(struct device *dev, struct device_attribute *attr,
+ char *buf);
+ ssize_t (*store)(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t len);
unsigned int attrcount = 0;
unsigned int i;
char *postfix;
--
2.37.1

2022-08-06 16:22:59

by Jonathan Cameron

Subject: Re: [PATCH] iio: Add names for function definition arguments.

On Sun, 31 Jul 2022 12:01:20 -0400
Joe Simmons-Talbott <[email protected]> wrote:

> As reported by checkpatch.pl add missing names for function definition
> arguments.
>
> Signed-off-by: Joe Simmons-Talbott <[email protected]>
Hi Joe,

I took this last week. Not sure why email didn't hit the list.

Thanks,

Jonathan

> ---
> drivers/iio/industrialio-event.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index b5e059e15b0a..0e2056894965 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -354,9 +354,10 @@ static int iio_device_add_event(struct iio_dev *indio_dev,
> enum iio_shared_by shared_by, const unsigned long *mask)
> {
> struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);
> - ssize_t (*show)(struct device *, struct device_attribute *, char *);
> - ssize_t (*store)(struct device *, struct device_attribute *,
> - const char *, size_t);
> + ssize_t (*show)(struct device *dev, struct device_attribute *attr,
> + char *buf);
> + ssize_t (*store)(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t len);
> unsigned int attrcount = 0;
> unsigned int i;
> char *postfix;