2022-08-01 04:11:44

by Sebin Sebastian

Subject: [PATCH -next] net: marvell: prestera: remove reduntant code

Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written
twice with the same value.

Fixes: Coverity CID 1519056 (Incorrect expression)
Signed-off-by: Sebin Sebastian <[email protected]>
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index c267ca1ccdba..0df904455d76 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -290,7 +290,7 @@ static int prestera_pcs_config(struct phylink_pcs *pcs,
const unsigned long *advertising,
bool permit_pause_to_mac)
{
- struct prestera_port *port = port = prestera_pcs_to_port(pcs);
+ struct prestera_port *port = prestera_pcs_to_port(pcs);
struct prestera_port_mac_config cfg_mac;
int err;

--
2.34.1

2022-08-02 04:00:04

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] net: marvell: prestera: remove reduntant code

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Mon, 1 Aug 2022 09:37:31 +0530 you wrote:
> Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written
> twice with the same value.
>
> Fixes: Coverity CID 1519056 (Incorrect expression)
> Signed-off-by: Sebin Sebastian <[email protected]>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [-next] net: marvell: prestera: remove reduntant code
https://git.kernel.org/netdev/net-next/c/969e26c63d30

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html