2022-08-02 05:33:35

by Samuel Holland

Subject: [PATCH v2 1/4] dt-bindings: sram: sunxi-sram: Add optional regulators child

Some sunxi SoCs have in-package regulators controlled by a register in
the system control MMIO block. Allow a child node for these regulators
in addition to SRAM child nodes.

Signed-off-by: Samuel Holland <[email protected]>
---

Changes in v2:
- New patch for v2

.../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
index 1c426c211e36..cc57836b2906 100644
--- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
+++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
@@ -56,6 +56,9 @@ properties:

ranges: true

+ regulators:
+ type: object
+
patternProperties:
"^sram@[a-z0-9]+":
type: object
--
2.35.1

2022-08-02 15:13:01

by Rob Herring (Arm)

Subject: Re: [PATCH v2 1/4] dt-bindings: sram: sunxi-sram: Add optional regulators child

On Tue, Aug 02, 2022 at 12:32:10AM -0500, Samuel Holland wrote:
> Some sunxi SoCs have in-package regulators controlled by a register in
> the system control MMIO block. Allow a child node for these regulators
> in addition to SRAM child nodes.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> Changes in v2:
> - New patch for v2
>
> .../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index 1c426c211e36..cc57836b2906 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -56,6 +56,9 @@ properties:
>
> ranges: true
>
> + regulators:
> + type: object

This should reference the regulator schema.

Also, it's preferred to have 1 complete example here rather than
piecemeal examples in each child schema.

> +
> patternProperties:
> "^sram@[a-z0-9]+":
> type: object
> --
> 2.35.1
>
>