2022-08-03 04:26:59

by Mario Limonciello

Subject: [PATCH v2 2/2] gpiolib: acpi: Add a quirk for Asus UM325UAZ

Asus UM325UAZ has GPIO 18 programmed as both an interrupt and a wake
source, but confirmed with internal team on this design this pin is
floating and shouldn't have been programmed. This causes lots of
spurious IRQs on the system and horrendous battery life.

Add a quirk to ignore attempts to program this pin on this system.

Reported-by: Pavel Krc <[email protected]>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216208
Reviewed-by: Hans de Goede <[email protected]>
Signed-off-by: Mario Limonciello <[email protected]>
---
v1->v2:
* Drop Tested-by tag
* Add Reviewed by tag

drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index f993f6f728ad..9c8ab1dc6087 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1573,6 +1573,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
.ignore_wake = "INT33FF:01@0",
},
},
+ {
+ /*
+ * Interrupt storm caused from edge triggered floating pin
+ * Found in BIOS UX325UAZ.300
+ * https://bugzilla.kernel.org/show_bug.cgi?id=216208
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook UX325UAZ_UM325UAZ"),
+ },
+ .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+ .ignore_interrupt = "AMDI0030:00@18",
+ },
+ },
{} /* Terminating entry */
};

--
2.34.1

2022-08-03 09:55:55

by Mika Westerberg

Subject: Re: [PATCH v2 2/2] gpiolib: acpi: Add a quirk for Asus UM325UAZ

On Tue, Aug 02, 2022 at 11:25:00PM -0500, Mario Limonciello wrote:
> Asus UM325UAZ has GPIO 18 programmed as both an interrupt and a wake
> source, but confirmed with internal team on this design this pin is
> floating and shouldn't have been programmed. This causes lots of
> spurious IRQs on the system and horrendous battery life.
>
> Add a quirk to ignore attempts to program this pin on this system.
>
> Reported-by: Pavel Krc <[email protected]>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216208
> Reviewed-by: Hans de Goede <[email protected]>
> Signed-off-by: Mario Limonciello <[email protected]>

Reviewed-by: Mika Westerberg <[email protected]>