2022-08-03 14:24:50

by Patrice CHOTARD

[permalink] [raw]
Subject: [PATCH 0/3] spi: stm32-qspi: some cleanup

From: Patrice Chotard <[email protected]>

This series removes unused parameter on some functions, no functional changes.

Patrice Chotard (3):
spi: stm32-qspi: Remove stm32_qspi_wait_poll_status() unused parameter
spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter
spi: stm32-qspi: Remove unused stm32_qspi_wait_cmd() parameter

drivers/spi/spi-stm32-qspi.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)

--
2.25.1



2022-08-03 14:26:11

by Patrice CHOTARD

[permalink] [raw]
Subject: [PATCH 1/3] spi: stm32-qspi: Remove stm32_qspi_wait_poll_status() unused parameter

From: Patrice Chotard <[email protected]>

op parameter is not used, remove it.

Signed-off-by: Patrice Chotard <[email protected]>
---
drivers/spi/spi-stm32-qspi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index c0239e405c39..94356781e75b 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -331,8 +331,7 @@ static int stm32_qspi_wait_cmd(struct stm32_qspi *qspi,
return err;
}

-static int stm32_qspi_wait_poll_status(struct stm32_qspi *qspi,
- const struct spi_mem_op *op)
+static int stm32_qspi_wait_poll_status(struct stm32_qspi *qspi)
{
u32 cr;

@@ -405,7 +404,7 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
writel_relaxed(op->addr.val, qspi->io_base + QSPI_AR);

if (qspi->fmode == CCR_FMODE_APM)
- err_poll_status = stm32_qspi_wait_poll_status(qspi, op);
+ err_poll_status = stm32_qspi_wait_poll_status(qspi);

err = stm32_qspi_tx(qspi, op);

--
2.25.1


2022-08-03 14:26:13

by Patrice CHOTARD

[permalink] [raw]
Subject: [PATCH 2/3] spi: stm32-qspi: Remove stm32_qspi_get_mode() unused parameter

From: Patrice Chotard <[email protected]>

Remove "struct stm32_qspi *qspi" from parameter list of
stm32_qspi_get_mode() as this parameter is unused.

Signed-off-by: Patrice Chotard <[email protected]>
---
drivers/spi/spi-stm32-qspi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
index 94356781e75b..622d1442a9b7 100644
--- a/drivers/spi/spi-stm32-qspi.c
+++ b/drivers/spi/spi-stm32-qspi.c
@@ -348,7 +348,7 @@ static int stm32_qspi_wait_poll_status(struct stm32_qspi *qspi)
return 0;
}

-static int stm32_qspi_get_mode(struct stm32_qspi *qspi, u8 buswidth)
+static int stm32_qspi_get_mode(u8 buswidth)
{
if (buswidth == 4)
return CCR_BUSWIDTH_4;
@@ -381,11 +381,11 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
ccr = qspi->fmode;
ccr |= FIELD_PREP(CCR_INST_MASK, op->cmd.opcode);
ccr |= FIELD_PREP(CCR_IMODE_MASK,
- stm32_qspi_get_mode(qspi, op->cmd.buswidth));
+ stm32_qspi_get_mode(op->cmd.buswidth));

if (op->addr.nbytes) {
ccr |= FIELD_PREP(CCR_ADMODE_MASK,
- stm32_qspi_get_mode(qspi, op->addr.buswidth));
+ stm32_qspi_get_mode(op->addr.buswidth));
ccr |= FIELD_PREP(CCR_ADSIZE_MASK, op->addr.nbytes - 1);
}

@@ -395,7 +395,7 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)

if (op->data.nbytes) {
ccr |= FIELD_PREP(CCR_DMODE_MASK,
- stm32_qspi_get_mode(qspi, op->data.buswidth));
+ stm32_qspi_get_mode(op->data.buswidth));
}

writel_relaxed(ccr, qspi->io_base + QSPI_CCR);
--
2.25.1