2022-08-03 16:28:31

by Conor Dooley

Subject: [PATCH v4] dt-bindings: gpio: sifive: add gpio-line-names

From: Atul Khare <[email protected]>

Fix device tree schema validation messages like 'gpio-line-names'
does not match any of the regexes: 'pinctrl-[0-9]+' From schema: ...
sifive,gpio.yaml'.

The bindings were missing the gpio-line-names element, which was
causing the dt-schema checker to trip-up.

Acked-by: Rob Herring <[email protected]>
Signed-off-by: Atul Khare <[email protected]>
Signed-off-by: Conor Dooley <[email protected]>
---
Changes since v3[0]:
- Dropped patch 1 & the now unneeded cover letter
- Added Rob's Ack
- Changed the patch title to include the subsystem

0 - https://lore.kernel.org/all/[email protected]/
---
Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
index 939e31c48081..fc095646adea 100644
--- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
@@ -46,6 +46,10 @@ properties:
maximum: 32
default: 16

+ gpio-line-names:
+ minItems: 1
+ maxItems: 32
+
gpio-controller: true

required:
--
2.37.1

2022-08-12 16:09:37

by Palmer Dabbelt

Subject: Re: [PATCH v4] dt-bindings: gpio: sifive: add gpio-line-names

On Wed, 03 Aug 2022 08:55:40 PDT (-0700), [email protected] wrote:
> From: Atul Khare <[email protected]>
>
> Fix device tree schema validation messages like 'gpio-line-names'
> does not match any of the regexes: 'pinctrl-[0-9]+' From schema: ...
> sifive,gpio.yaml'.
>
> The bindings were missing the gpio-line-names element, which was
> causing the dt-schema checker to trip-up.
>
> Acked-by: Rob Herring <[email protected]>
> Signed-off-by: Atul Khare <[email protected]>
> Signed-off-by: Conor Dooley <[email protected]>
> ---
> Changes since v3[0]:
> - Dropped patch 1 & the now unneeded cover letter
> - Added Rob's Ack
> - Changed the patch title to include the subsystem
>
> 0 - https://lore.kernel.org/all/[email protected]/
> ---
> Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> index 939e31c48081..fc095646adea 100644
> --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> @@ -46,6 +46,10 @@ properties:
> maximum: 32
> default: 16
>
> + gpio-line-names:
> + minItems: 1
> + maxItems: 32
> +
> gpio-controller: true
>
> required:

Thanks, this is on for-next.