2022-08-04 01:37:44

by Yang Li

Subject: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c

util/topdown.h is included twice in builtin-stat.c,
remove one of them.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
tools/perf/builtin-stat.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 3d22543fc305..e326226656e4 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -71,7 +71,6 @@
#include "util/bpf_counter.h"
#include "util/iostat.h"
#include "util/pmu-hybrid.h"
- #include "util/topdown.h"
#include "asm/bug.h"

#include <linux/time64.h>
--
2.20.1.7.g153144c

2022-08-04 16:04:43

by Ian Rogers

Subject: Re: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c

On Wed, Aug 3, 2022 at 5:52 PM Yang Li <[email protected]> wrote:
>
> util/topdown.h is included twice in builtin-stat.c,
> remove one of them.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Tested-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> tools/perf/builtin-stat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 3d22543fc305..e326226656e4 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -71,7 +71,6 @@
> #include "util/bpf_counter.h"
> #include "util/iostat.h"
> #include "util/pmu-hybrid.h"
> - #include "util/topdown.h"
> #include "asm/bug.h"
>
> #include <linux/time64.h>
> --
> 2.20.1.7.g153144c
>

2022-08-12 20:12:48

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c

Em Thu, Aug 04, 2022 at 08:32:22AM -0700, Ian Rogers escreveu:
> On Wed, Aug 3, 2022 at 5:52 PM Yang Li <[email protected]> wrote:
> >
> > util/topdown.h is included twice in builtin-stat.c,
> > remove one of them.
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Tested-by: Ian Rogers <[email protected]>

Thanks, applied.

- Arnaldo


> Thanks,
> Ian
>
> > ---
> > tools/perf/builtin-stat.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index 3d22543fc305..e326226656e4 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -71,7 +71,6 @@
> > #include "util/bpf_counter.h"
> > #include "util/iostat.h"
> > #include "util/pmu-hybrid.h"
> > - #include "util/topdown.h"
> > #include "asm/bug.h"
> >
> > #include <linux/time64.h>
> > --
> > 2.20.1.7.g153144c
> >

--

- Arnaldo