2022-08-05 12:20:51

by Colin Ian King

Subject: [PATCH] ALSA: ice1712: remove redundant assignment to new

The variable new is initialized with a value but it is never read. It is
being re-assigned a new value in every case path in the following switch
statement. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored
to 'new' is used in the enclosing expression, the value is never actually
read from 'new' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
sound/pci/ice1712/quartet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/ice1712/quartet.c b/sound/pci/ice1712/quartet.c
index 0dfa093f7dca..20b3e8f94719 100644
--- a/sound/pci/ice1712/quartet.c
+++ b/sound/pci/ice1712/quartet.c
@@ -566,7 +566,7 @@ static int qtet_ain12_sw_put(struct snd_kcontrol *kcontrol,
{
struct snd_ice1712 *ice = snd_kcontrol_chip(kcontrol);
unsigned int old, new, tmp, masked_old;
- old = new = get_scr(ice);
+ old = get_scr(ice);
masked_old = old & (SCR_AIN12_SEL1 | SCR_AIN12_SEL0);
tmp = ucontrol->value.integer.value[0];
if (tmp == 2)
--
2.35.3

2022-08-05 13:57:53

by Takashi Iwai

Subject: Re: [PATCH] ALSA: ice1712: remove redundant assignment to new

On Fri, 05 Aug 2022 14:04:39 +0200,
Colin Ian King wrote:
>
> The variable new is initialized with a value but it is never read. It is
> being re-assigned a new value in every case path in the following switch
> statement. The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/pci/ice1712/quartet.c:569:8: warning: Although the value stored
> to 'new' is used in the enclosing expression, the value is never actually
> read from 'new' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi