2022-08-06 09:12:10

by Vadym Kochan

Subject: [PATCH 1/3] dt-bindings: mmc: xenon: Add compatible string for Xenon SDHCI on AC5 SoC

It indicates the Xenon SDHCI on AC5 SoC so the driver will try to fixup
the 2G address space limitation issue.

Signed-off-by: Vadym Kochan <[email protected]>
---
Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
index 3ee758886558..17cda847e0a3 100644
--- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
@@ -34,6 +34,9 @@ properties:
- const: marvell,armada-3700-sdhci
- const: marvell,sdhci-xenon

+ - items:
+ - const: marvell,ac5-sdhci
+
reg:
minItems: 1
maxItems: 2
--
2.17.1

2022-08-08 09:28:53

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: mmc: xenon: Add compatible string for Xenon SDHCI on AC5 SoC

On 06/08/2022 11:58, Vadym Kochan wrote:
> It indicates the Xenon SDHCI on AC5 SoC so the driver will try to fixup
> the 2G address space limitation issue.
>
> Signed-off-by: Vadym Kochan <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> index 3ee758886558..17cda847e0a3 100644
> --- a/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
> @@ -34,6 +34,9 @@ properties:
> - const: marvell,armada-3700-sdhci
> - const: marvell,sdhci-xenon
>
> + - items:
> + - const: marvell,ac5-sdhci

These are not items. Should be part of existing enum.

You missed updating allOf:if:then.

Best regards,
Krzysztof