2022-08-07 13:21:12

by Molly Sophia

Subject: [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers

The pin numbers for UFS_RESET and SDC2_* are not
consistent in the pinctrl driver for sc8180x.
So fix it.

Signed-off-by: Molly Sophia <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-sc8180x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
index b4bf009fe23e..704a99d2f93c 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
@@ -530,10 +530,10 @@ DECLARE_MSM_GPIO_PINS(187);
DECLARE_MSM_GPIO_PINS(188);
DECLARE_MSM_GPIO_PINS(189);

-static const unsigned int sdc2_clk_pins[] = { 190 };
-static const unsigned int sdc2_cmd_pins[] = { 191 };
-static const unsigned int sdc2_data_pins[] = { 192 };
-static const unsigned int ufs_reset_pins[] = { 193 };
+static const unsigned int ufs_reset_pins[] = { 190 };
+static const unsigned int sdc2_clk_pins[] = { 191 };
+static const unsigned int sdc2_cmd_pins[] = { 192 };
+static const unsigned int sdc2_data_pins[] = { 193 };

enum sc8180x_functions {
msm_mux_adsp_ext,
--
2.25.1

2022-08-08 04:22:34

by Bjorn Andersson

Subject: Re: [PATCH 2/2] pinctrl: qcom: sc8180x: Fix wrong pin numbers

On Sun 07 Aug 05:26 PDT 2022, Molly Sophia wrote:

> The pin numbers for UFS_RESET and SDC2_* are not
> consistent in the pinctrl driver for sc8180x.
> So fix it.
>
> Signed-off-by: Molly Sophia <[email protected]>

Fixes: 97423113ec4b ("pinctrl: qcom: Add sc8180x TLMM driver")
Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/pinctrl/qcom/pinctrl-sc8180x.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc8180x.c b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> index b4bf009fe23e..704a99d2f93c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc8180x.c
> @@ -530,10 +530,10 @@ DECLARE_MSM_GPIO_PINS(187);
> DECLARE_MSM_GPIO_PINS(188);
> DECLARE_MSM_GPIO_PINS(189);
>
> -static const unsigned int sdc2_clk_pins[] = { 190 };
> -static const unsigned int sdc2_cmd_pins[] = { 191 };
> -static const unsigned int sdc2_data_pins[] = { 192 };
> -static const unsigned int ufs_reset_pins[] = { 193 };
> +static const unsigned int ufs_reset_pins[] = { 190 };
> +static const unsigned int sdc2_clk_pins[] = { 191 };
> +static const unsigned int sdc2_cmd_pins[] = { 192 };
> +static const unsigned int sdc2_data_pins[] = { 193 };
>
> enum sc8180x_functions {
> msm_mux_adsp_ext,
> --
> 2.25.1
>