2022-08-09 19:20:30

by Colin Ian King

Subject: [PATCH] ALSA: usb-audio: make read-only array marker static const

Don't populate the read-only array marker on the stack but instead make
it static const. Also makes the object code a little smaller.

Signed-off-by: Colin Ian King <[email protected]>
---
sound/usb/pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index e692ae04436a..d45d1d7e6664 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -1269,7 +1269,7 @@ static inline void fill_playback_urb_dsd_dop(struct snd_usb_substream *subs,
unsigned int wrap = subs->buffer_bytes;
u8 *dst = urb->transfer_buffer;
u8 *src = runtime->dma_area;
- u8 marker[] = { 0x05, 0xfa };
+ static const u8 marker[] = { 0x05, 0xfa };
unsigned int queued = 0;

/*
--
2.35.3

2022-08-10 10:11:08

by Takashi Iwai

Subject: Re: [PATCH] ALSA: usb-audio: make read-only array marker static const

On Tue, 09 Aug 2022 20:15:44 +0200,
Colin Ian King wrote:
>
> Don't populate the read-only array marker on the stack but instead make
> it static const. Also makes the object code a little smaller.
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied.


Takashi