2022-08-10 23:37:35

by André Almeida

Subject: [PATCH v3 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

Add comments to document gfx_off related members of struct amdgpu_gfx.

Signed-off-by: André Almeida <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
index 1b8b4a5270c9..8abdf41d0f83 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
@@ -332,12 +332,12 @@ struct amdgpu_gfx {
uint32_t srbm_soft_reset;

/* gfx off */
- bool gfx_off_state; /* true: enabled, false: disabled */
- struct mutex gfx_off_mutex;
- uint32_t gfx_off_req_count; /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
- struct delayed_work gfx_off_delay_work;
- uint32_t gfx_off_residency;
- uint64_t gfx_off_entrycount;
+ bool gfx_off_state; /* true: enabled, false: disabled */
+ struct mutex gfx_off_mutex; /* mutex to change gfxoff state */
+ uint32_t gfx_off_req_count; /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
+ struct delayed_work gfx_off_delay_work; /* async work to set gfx block off */
+ uint32_t gfx_off_residency; /* last logged residency */
+ uint64_t gfx_off_entrycount; /* count of times GPU has get into GFXOFF state */

/* pipe reservation */
struct mutex pipe_reserve_mutex;
--
2.37.1

2022-08-16 01:37:53

by Alex Deucher

Subject: Re: [PATCH v3 4/4] drm/amdgpu: Document gfx_off members of struct amdgpu_gfx

Applied the series. Thanks!

Alex

On Wed, Aug 10, 2022 at 7:30 PM André Almeida <[email protected]> wrote:
>
> Add comments to document gfx_off related members of struct amdgpu_gfx.
>
> Signed-off-by: André Almeida <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> index 1b8b4a5270c9..8abdf41d0f83 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h
> @@ -332,12 +332,12 @@ struct amdgpu_gfx {
> uint32_t srbm_soft_reset;
>
> /* gfx off */
> - bool gfx_off_state; /* true: enabled, false: disabled */
> - struct mutex gfx_off_mutex;
> - uint32_t gfx_off_req_count; /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
> - struct delayed_work gfx_off_delay_work;
> - uint32_t gfx_off_residency;
> - uint64_t gfx_off_entrycount;
> + bool gfx_off_state; /* true: enabled, false: disabled */
> + struct mutex gfx_off_mutex; /* mutex to change gfxoff state */
> + uint32_t gfx_off_req_count; /* default 1, enable gfx off: dec 1, disable gfx off: add 1 */
> + struct delayed_work gfx_off_delay_work; /* async work to set gfx block off */
> + uint32_t gfx_off_residency; /* last logged residency */
> + uint64_t gfx_off_entrycount; /* count of times GPU has get into GFXOFF state */
>
> /* pipe reservation */
> struct mutex pipe_reserve_mutex;
> --
> 2.37.1
>