2022-08-11 14:32:15

by Philippe Schenker

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy

From: Philippe Schenker <[email protected]>

The Verdin iMX8M Mini System on Module does not have USB-ID signal
connected on Verdin USB_2 (usbotg2). On Verdin Development board this is
no problem, as we have connected a USB-Hub that is always connected.

However, if Verdin USB_2 is desired to be used as a single USB-Host port
the chipidea driver does not detect if a USB device is plugged into this
port, due to runtime pm shutting down the PHY.

Add the power-domain &pgc_otg2 to &usbphynop2 in order to detect
plugging events and enumerate the usb device.

Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
Signed-off-by: Philippe Schenker <[email protected]>

---

Changes in v2:
- Changed word VBUS to USB-ID, as from mailinglist discussions I
obviously mixed that up before.

arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index d1b4582f44c4..34808aa36c2b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -745,6 +745,7 @@ &usbphynop1 {
};

&usbphynop2 {
+ power-domains = <&pgc_otg2>;
vcc-supply = <&reg_vdd_3v3>;
};

--
2.37.1


2022-08-22 01:38:58

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: verdin-imx8mm: add otg2 pd to usbphy

On Thu, Aug 11, 2022 at 04:07:38PM +0200, Philippe Schenker wrote:
> From: Philippe Schenker <[email protected]>
>
> The Verdin iMX8M Mini System on Module does not have USB-ID signal
> connected on Verdin USB_2 (usbotg2). On Verdin Development board this is
> no problem, as we have connected a USB-Hub that is always connected.
>
> However, if Verdin USB_2 is desired to be used as a single USB-Host port
> the chipidea driver does not detect if a USB device is plugged into this
> port, due to runtime pm shutting down the PHY.
>
> Add the power-domain &pgc_otg2 to &usbphynop2 in order to detect
> plugging events and enumerate the usb device.
>
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <[email protected]>

Applied, thanks!