2022-08-10 23:37:41

by Chen Lin

Subject: [PATCH] dpaa2-eth: trace the allocated address instead of page struct

Follow the commit 27c874867c4(dpaa2-eth: Use a single page per Rx buffer),
we should trace the allocated address instead of page struct.

Signed-off-by: Chen Lin <[email protected]>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index cd9ec8052..75d515726 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1660,8 +1660,8 @@ static int dpaa2_eth_add_bufs(struct dpaa2_eth_priv *priv,
buf_array[i] = addr;

/* tracing point */
- trace_dpaa2_eth_buf_seed(priv->net_dev,
- page, DPAA2_ETH_RX_BUF_RAW_SIZE,
+ trace_dpaa2_eth_buf_seed(priv->net_dev, page_address(page),
+ DPAA2_ETH_RX_BUF_RAW_SIZE,
addr, priv->rx_buf_size,
bpid);
}
--
2.25.1

2022-08-11 15:09:39

by Ioana Ciornei

Subject: Re: [PATCH] dpaa2-eth: trace the allocated address instead of page struct

On Thu, Aug 11, 2022 at 07:29:48AM +0800, Chen Lin wrote:
> Follow the commit 27c874867c4(dpaa2-eth: Use a single page per Rx buffer),
> we should trace the allocated address instead of page struct.
>
> Signed-off-by: Chen Lin <[email protected]>

Reviewed-by: Ioana Ciornei <[email protected]>

Is this intended for the net tree? In that case, maybe it would be a
good idea to add a fixes tag to the commit that you are already
referencing.

Ioana

2022-08-11 15:52:02

by Chen Lin

Subject: [PATCH v2] dpaa2-eth: trace the allocated address instead of page struct

We should trace the allocated address instead of page struct.

Fixes: 27c874867c4 ("dpaa2-eth: Use a single page per Rx buffer")
Signed-off-by: Chen Lin <[email protected]>
Reviewed-by: Ioana Ciornei <[email protected]>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index cd9ec8052..75d515726 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1660,8 +1660,8 @@ static int dpaa2_eth_add_bufs(struct dpaa2_eth_priv *priv,
buf_array[i] = addr;

/* tracing point */
- trace_dpaa2_eth_buf_seed(priv->net_dev,
- page, DPAA2_ETH_RX_BUF_RAW_SIZE,
+ trace_dpaa2_eth_buf_seed(priv->net_dev, page_address(page),
+ DPAA2_ETH_RX_BUF_RAW_SIZE,
addr, priv->rx_buf_size,
bpid);
}
--
2.25.1

2022-08-11 18:01:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] dpaa2-eth: trace the allocated address instead of page struct

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 11 Aug 2022 23:16:51 +0800 you wrote:
> We should trace the allocated address instead of page struct.
>
> Fixes: 27c874867c4 ("dpaa2-eth: Use a single page per Rx buffer")
> Signed-off-by: Chen Lin <[email protected]>
> Reviewed-by: Ioana Ciornei <[email protected]>
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [v2] dpaa2-eth: trace the allocated address instead of page struct
https://git.kernel.org/netdev/net/c/e34f49348f8b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html