2022-08-12 18:13:27

by Kristen Carlson Accardi

Subject: [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning

OpenSSL 3.0 deprecates some of the functions used in the SGX
selftests, causing build errors on new distros. For now ignore
the warnings until support for the functions is no longer
available and mark FIXME so that it can be clear this should
be removed at some point.

Signed-off-by: Kristen Carlson Accardi <[email protected]>
---
tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
index 50c5ab1aa6fa..a07896a46364 100644
--- a/tools/testing/selftests/sgx/sigstruct.c
+++ b/tools/testing/selftests/sgx/sigstruct.c
@@ -17,6 +17,12 @@
#include "defines.h"
#include "main.h"

+/*
+ * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
+ * the warnings.
+ */
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
struct q1q2_ctx {
BN_CTX *bn_ctx;
BIGNUM *m;
--
2.36.1

2022-08-14 19:40:05

by Jarkko Sakkinen

Subject: Re: [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning

On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
> OpenSSL 3.0 deprecates some of the functions used in the SGX
> selftests, causing build errors on new distros. For now ignore
> the warnings until support for the functions is no longer
> available and mark FIXME so that it can be clear this should
> be removed at some point.
>
> Signed-off-by: Kristen Carlson Accardi <[email protected]>
> ---
> tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
> index 50c5ab1aa6fa..a07896a46364 100644
> --- a/tools/testing/selftests/sgx/sigstruct.c
> +++ b/tools/testing/selftests/sgx/sigstruct.c
> @@ -17,6 +17,12 @@
> #include "defines.h"
> #include "main.h"
>
> +/*
> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
> + * the warnings.
> + */
> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> +
> struct q1q2_ctx {
> BN_CTX *bn_ctx;
> BIGNUM *m;
> --
> 2.36.1
>

Thank you.


Reviewed-by: Jarkko Sakkinen <[email protected]>

BR, Jarkko

2022-08-16 06:17:31

by Shuah Khan

Subject: Re: [PATCH v2] selftests/sgx: Ignore OpenSSL 3.0 deprecated functions warning

On 8/14/22 1:22 PM, Jarkko Sakkinen wrote:
> On Fri, Aug 12, 2022 at 11:07:13AM -0700, Kristen Carlson Accardi wrote:
>> OpenSSL 3.0 deprecates some of the functions used in the SGX
>> selftests, causing build errors on new distros. For now ignore
>> the warnings until support for the functions is no longer
>> available and mark FIXME so that it can be clear this should
>> be removed at some point.
>>
>> Signed-off-by: Kristen Carlson Accardi <[email protected]>
>> ---
>> tools/testing/selftests/sgx/sigstruct.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
>> index 50c5ab1aa6fa..a07896a46364 100644
>> --- a/tools/testing/selftests/sgx/sigstruct.c
>> +++ b/tools/testing/selftests/sgx/sigstruct.c
>> @@ -17,6 +17,12 @@
>> #include "defines.h"
>> #include "main.h"
>>
>> +/*
>> + * FIXME: OpenSSL 3.0 has deprecated some functions. For now just ignore
>> + * the warnings.
>> + */
>> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>> +
>> struct q1q2_ctx {
>> BN_CTX *bn_ctx;
>> BIGNUM *m;
>> --
>> 2.36.1
>>
>
> Thank you.
>
>
> Reviewed-by: Jarkko Sakkinen <[email protected]>
>
> BR, Jarkko
>

Thank you both.

Applied for rc2/3

thanks,
-- Shuah