2022-08-13 15:28:08

by min tang

Subject: [PATCH] drm/i915/gt: Unneeded semicolon

There is no semicolon after '}' in line 648.

Signed-off-by: min tang <[email protected]>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
tools/power/x86/intel-speed-select/hfi-events.c | 2 +-
tools/testing/selftests/timers/nanosleep.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 2c35324b5f68..a69b244f14d0 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
while (sg && sg_dma_len(sg)) {
len += sg_dma_len(sg);
sg = sg_next(sg);
- };
+ }

return len;
}
diff --git a/tools/power/x86/intel-speed-select/hfi-events.c b/tools/power/x86/intel-speed-select/hfi-events.c
index 761375062505..f0ed69721308 100644
--- a/tools/power/x86/intel-speed-select/hfi-events.c
+++ b/tools/power/x86/intel-speed-select/hfi-events.c
@@ -144,7 +144,7 @@ static int family_handler(struct nl_msg *msg, void *arg)
continue;
res->id = nla_get_u32(tb2[CTRL_ATTR_MCAST_GRP_ID]);
break;
- };
+ }

return 0;
}
diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
index 71b5441c2fd9..433a09676aeb 100644
--- a/tools/testing/selftests/timers/nanosleep.c
+++ b/tools/testing/selftests/timers/nanosleep.c
@@ -72,7 +72,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}

--
2.17.1

2022-08-15 10:14:35

by Jani Nikula

Subject: Re: [PATCH] drm/i915/gt: Unneeded semicolon

On Sat, 13 Aug 2022, min tang <[email protected]> wrote:
> There is no semicolon after '}' in line 648.
>
> Signed-off-by: min tang <[email protected]>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-

This part is fine.

> tools/power/x86/intel-speed-select/hfi-events.c | 2 +-
> tools/testing/selftests/timers/nanosleep.c | 2 +-

These need to be split out and sent to their respective subsystems.

BR,
Jani.

> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> diff --git a/tools/power/x86/intel-speed-select/hfi-events.c b/tools/power/x86/intel-speed-select/hfi-events.c
> index 761375062505..f0ed69721308 100644
> --- a/tools/power/x86/intel-speed-select/hfi-events.c
> +++ b/tools/power/x86/intel-speed-select/hfi-events.c
> @@ -144,7 +144,7 @@ static int family_handler(struct nl_msg *msg, void *arg)
> continue;
> res->id = nla_get_u32(tb2[CTRL_ATTR_MCAST_GRP_ID]);
> break;
> - };
> + }
>
> return 0;
> }
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 71b5441c2fd9..433a09676aeb 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
> return "CLOCK_BOOTTIME_ALARM";
> case CLOCK_TAI:
> return "CLOCK_TAI";
> - };
> + }
> return "UNKNOWN_CLOCKID";
> }

--
Jani Nikula, Intel Open Source Graphics Center