2022-08-14 09:54:26

by Jilin Yuan

[permalink] [raw]
Subject: [PATCH] net/ppp: fix repeated words in comments

Delete the redundant word 'the'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/net/ppp/ppp_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 4a365f15533e..942c7e7372d9 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -2969,7 +2969,7 @@ ppp_unregister_channel(struct ppp_channel *chan)

/*
* This ensures that we have returned from any calls into the
- * the channel's start_xmit or ioctl routine before we proceed.
+ * channel's start_xmit or ioctl routine before we proceed.
*/
down_write(&pch->chan_sem);
spin_lock_bh(&pch->downl);
--
2.36.1


2022-08-17 02:52:01

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net/ppp: fix repeated words in comments

On Sun, 14 Aug 2022 17:22:55 +0800 Jilin Yuan wrote:
> * This ensures that we have returned from any calls into the
> - * the channel's start_xmit or ioctl routine before we proceed.
> + * channel's start_xmit or ioctl routine before we proceed.

It's better to remove the 'the' at the end of the line.
Generally accepted typography rules are that the articles
(a, an, the) should not be followed by a line break.