2022-08-16 00:48:06

by Xin Gao

Subject: [PATCH] ARM: Fix double word in comments

Delete repeated word "in" in comments.

Signed-off-by: Xin Gao <[email protected]>
---
arch/arm/mach-pxa/palm27x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
index 1a8d25eecac3..116183859357 100644
--- a/arch/arm/mach-pxa/palm27x.c
+++ b/arch/arm/mach-pxa/palm27x.c
@@ -160,7 +160,7 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode)
#if defined(CONFIG_USB_PXA27X) || \
defined(CONFIG_USB_PXA27X_MODULE)

-/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
+/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
.dev_id = "gpio-vbus",
.table = {
--
2.30.2

2022-08-16 03:37:18

by Robin Murphy

Subject: Re: [PATCH] ARM: Fix double word in comments

On 2022-08-15 21:00, Xin Gao wrote:
> Delete repeated word "in" in comments.

It is not grammatically incorrect though. The second "in" is the
preposition here, while the first is an adverb - "fill in" is a term in
its own right, particularly in the context of information, whereas
"fill" tends to suggest a more physical context. For instance, one might
typically say "I filled the bottle" (with liquid), but "I filled in the
application form" (with data).

Robin.

> Signed-off-by: Xin Gao <[email protected]>
> ---
> arch/arm/mach-pxa/palm27x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
> index 1a8d25eecac3..116183859357 100644
> --- a/arch/arm/mach-pxa/palm27x.c
> +++ b/arch/arm/mach-pxa/palm27x.c
> @@ -160,7 +160,7 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode)
> #if defined(CONFIG_USB_PXA27X) || \
> defined(CONFIG_USB_PXA27X_MODULE)
>
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
> static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
> .dev_id = "gpio-vbus",
> .table = {