2022-08-16 03:42:10

by Michael Walle

Subject: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port

Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
port. This has always been wrong, i.e. the board code used to set up
both ports, but the driver will play nice and return -ENODEV if the
assiciated PHY is not found. Nevertheless, it is wrong. Remove it.

Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
Signed-off-by: Michael Walle <[email protected]>
---
arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
index 321a40a98ed2..88b70ba1c8fe 100644
--- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
+++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
@@ -218,22 +218,11 @@ hdd_power: regulator@2 {
&mdio {
status = "okay";

- ethphy0: ethernet-phy@0 {
- reg = <0>;
- };
-
ethphy1: ethernet-phy@8 {
reg = <8>;
};
};

-&eth0 {
- status = "okay";
- ethernet0-port@0 {
- phy-handle = <&ethphy0>;
- };
-};
-
&eth1 {
status = "okay";
ethernet1-port@0 {
--
2.30.2

2022-08-19 00:26:04

by Andrew Lunn

Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port

On Tue, Aug 16, 2022 at 02:10:25AM +0200, Michael Walle wrote:
> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2022-09-02 15:14:16

by Gregory CLEMENT

Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port

Michael Walle <[email protected]> writes:

> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <[email protected]>

Applied on mvebu/dt

Thanks,

Gregory
> ---
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 321a40a98ed2..88b70ba1c8fe 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -218,22 +218,11 @@ hdd_power: regulator@2 {
> &mdio {
> status = "okay";
>
> - ethphy0: ethernet-phy@0 {
> - reg = <0>;
> - };
> -
> ethphy1: ethernet-phy@8 {
> reg = <8>;
> };
> };
>
> -&eth0 {
> - status = "okay";
> - ethernet0-port@0 {
> - phy-handle = <&ethphy0>;
> - };
> -};
> -
> &eth1 {
> status = "okay";
> ethernet1-port@0 {
> --
> 2.30.2
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com