On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> File already contains code that is common along balloon
> drivers so rename it to reflect its contents.
> mm/balloon_compaction.c -> mm/balloon_common.c
>
> Signed-off-by: Alexander Atanasov <[email protected]>
> ---
> MAINTAINERS | 4 ++--
> arch/powerpc/platforms/pseries/cmm.c | 2 +-
> drivers/misc/vmw_balloon.c | 2 +-
> drivers/virtio/virtio_balloon.c | 2 +-
> include/linux/{balloon_compaction.h => balloon_common.h} | 2 +-
> mm/Makefile | 2 +-
> mm/{balloon_compaction.c => balloon_common.c} | 4 ++--
> mm/migrate.c | 2 +-
> mm/vmscan.c | 2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
> rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
Why rename the .h file? It still handles the "balloon compaction"
logic.
thanks,
greg k-h
Hello,
On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
>> rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
>
> Why rename the .h file? It still handles the "balloon compaction"
> logic.
File contains code that is common to balloon drivers,
compaction is only part of it. Series add more code to it.
Since it was suggested to use it for such common code.
I find that common becomes a better name for it so the rename.
I can drop the rename easy on next iteration if you suggest to.
--
Regards,
Alexander Atanasov
On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> Hello,
>
> On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
>
> > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
> >
> > Why rename the .h file? It still handles the "balloon compaction"
> > logic.
>
> File contains code that is common to balloon drivers,
> compaction is only part of it. Series add more code to it.
> Since it was suggested to use it for such common code.
> I find that common becomes a better name for it so the rename.
> I can drop the rename easy on next iteration if you suggest to.
"balloon_common.h" is very vague, you should only need one balloon.h
file in the include/linux/ directory, right, so of course it is "common"
:)
thanks,
greg "naming is hard" k-h
On Tue, Aug 16, 2022 at 01:56:32PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Aug 16, 2022 at 02:47:22PM +0300, Alexander Atanasov wrote:
> > Hello,
> >
> > On 16.08.22 12:49, Greg Kroah-Hartman wrote:
> > > On Tue, Aug 16, 2022 at 12:41:14PM +0300, Alexander Atanasov wrote:
> >
> > > > rename include/linux/{balloon_compaction.h => balloon_common.h} (99%)
> > >
> > > Why rename the .h file? It still handles the "balloon compaction"
> > > logic.
> >
> > File contains code that is common to balloon drivers,
> > compaction is only part of it. Series add more code to it.
> > Since it was suggested to use it for such common code.
> > I find that common becomes a better name for it so the rename.
> > I can drop the rename easy on next iteration if you suggest to.
>
> "balloon_common.h" is very vague, you should only need one balloon.h
> file in the include/linux/ directory, right, so of course it is "common"
> :)
>
> thanks,
>
> greg "naming is hard" k-h
Yea, just call it balloon.h and balloon.c then.
--
MST