2022-08-16 10:49:32

by Denis Arefev

Subject: [PATCH 3/3] i915-pmu: Add extra check NULL

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Denis Arefev <[email protected]>
---
drivers/gpu/drm/i915/i915_pmu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
index 34a7f0ef1f67..33db49ffac3d 100644
--- a/drivers/gpu/drm/i915/i915_pmu.c
+++ b/drivers/gpu/drm/i915/i915_pmu.c
@@ -704,8 +704,7 @@ static void i915_pmu_disable(struct perf_event *event)
* Decrement the reference count and clear the enabled
* bitmask when the last listener on an event goes away.
*/
- if(engine != NULL)
- {
+ if (engine != NULL) {
if (--engine->pmu.enable_count[sample] == 0)
engine->pmu.enable &= ~BIT(sample);
}
--
2.25.1

2022-08-16 10:50:08

by Jani Nikula

Subject: Re: [PATCH 3/3] i915-pmu: Add extra check NULL

On Tue, 16 Aug 2022, Denis Arefev <[email protected]> wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

The subject prefix should be something along the lines of
"drm/i915/pmu".

The subject is misleading; there are no functional changes here, just
whitespace changes. I'm guessing you intended to send something else?

Finally, the commit message is primarily for describing why the change
is being made, not to advertize organizations or tools.


BR,
Jani.


>
> Signed-off-by: Denis Arefev <[email protected]>
> ---
> drivers/gpu/drm/i915/i915_pmu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c
> index 34a7f0ef1f67..33db49ffac3d 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.c
> +++ b/drivers/gpu/drm/i915/i915_pmu.c
> @@ -704,8 +704,7 @@ static void i915_pmu_disable(struct perf_event *event)
> * Decrement the reference count and clear the enabled
> * bitmask when the last listener on an event goes away.
> */
> - if(engine != NULL)
> - {
> + if (engine != NULL) {
> if (--engine->pmu.enable_count[sample] == 0)
> engine->pmu.enable &= ~BIT(sample);
> }

--
Jani Nikula, Intel Open Source Graphics Center