2022-08-16 12:40:20

by Lukasz Luba

[permalink] [raw]
Subject: [PATCH] docs: scheduler: Update new path for the sysctl knobs

Add missing update for the documentation bit of some scheduler knob.
The knobs have been moved to /debug/sched/ location (with adjusted names).

Signed-off-by: Lukasz Luba <[email protected]>
---
Documentation/scheduler/sched-design-CFS.rst | 2 +-
Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/scheduler/sched-design-CFS.rst b/Documentation/scheduler/sched-design-CFS.rst
index 59b2d1fb4dc4..03db55504515 100644
--- a/Documentation/scheduler/sched-design-CFS.rst
+++ b/Documentation/scheduler/sched-design-CFS.rst
@@ -94,7 +94,7 @@ other HZ detail. Thus the CFS scheduler has no notion of "timeslices" in the
way the previous scheduler had, and has no heuristics whatsoever. There is
only one central tunable (you have to switch on CONFIG_SCHED_DEBUG):

- /proc/sys/kernel/sched_min_granularity_ns
+ /sys/kernel/debug/sched/min_granularity_ns

which can be used to tune the scheduler from "desktop" (i.e., low latencies) to
"server" (i.e., good batching) workloads. It defaults to a setting suitable
diff --git a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
index 26b0f36f793d..3076402406c4 100644
--- a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
+++ b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
@@ -80,7 +80,7 @@ p->se.vruntime。一旦p->se.vruntime变得足够大,其它的任务将成为
CFS使用纳秒粒度的计时,不依赖于任何jiffies或HZ的细节。因此CFS并不像之前的调度器那样
有“时间片”的概念,也没有任何启发式的设计。唯一可调的参数(你需要打开CONFIG_SCHED_DEBUG)是:

- /proc/sys/kernel/sched_min_granularity_ns
+ /sys/kernel/debug/sched/min_granularity_ns

它可以用来将调度器从“桌面”模式(也就是低时延)调节为“服务器”(也就是高批处理)模式。
它的默认设置是适合桌面的工作负载。SCHED_BATCH也被CFS调度器模块处理。
--
2.17.1


2022-08-17 02:54:45

by Yanteng Si

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs


在 2022/8/16 20:19, Lukasz Luba 写道:
> Add missing update for the documentation bit of some scheduler knob.
> The knobs have been moved to /debug/sched/ location (with adjusted names).
>
> Signed-off-by: Lukasz Luba <[email protected]>

Tested-by: Yanteng Si <[email protected]>


CC Yizhou


Thanks,

Yanteng

> ---
> Documentation/scheduler/sched-design-CFS.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-design-CFS.rst b/Documentation/scheduler/sched-design-CFS.rst
> index 59b2d1fb4dc4..03db55504515 100644
> --- a/Documentation/scheduler/sched-design-CFS.rst
> +++ b/Documentation/scheduler/sched-design-CFS.rst
> @@ -94,7 +94,7 @@ other HZ detail. Thus the CFS scheduler has no notion of "timeslices" in the
> way the previous scheduler had, and has no heuristics whatsoever. There is
> only one central tunable (you have to switch on CONFIG_SCHED_DEBUG):
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> which can be used to tune the scheduler from "desktop" (i.e., low latencies) to
> "server" (i.e., good batching) workloads. It defaults to a setting suitable
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> index 26b0f36f793d..3076402406c4 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> @@ -80,7 +80,7 @@ p->se.vruntime。一旦p->se.vruntime变得足够大,其它的任务将成为
> CFS使用纳秒粒度的计时,不依赖于任何jiffies或HZ的细节。因此CFS并不像之前的调度器那样
> 有“时间片”的概念,也没有任何启发式的设计。唯一可调的参数(你需要打开CONFIG_SCHED_DEBUG)是:
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> 它可以用来将调度器从“桌面”模式(也就是低时延)调节为“服务器”(也就是高批处理)模式。
> 它的默认设置是适合桌面的工作负载。SCHED_BATCH也被CFS调度器模块处理。

2022-08-17 03:01:46

by Alex Shi

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs

On Tue, Aug 16, 2022 at 8:19 PM Lukasz Luba <[email protected]> wrote:
>
> Add missing update for the documentation bit of some scheduler knob.
> The knobs have been moved to /debug/sched/ location (with adjusted names).
>
> Signed-off-by: Lukasz Luba <[email protected]>

Reviewed-by: Alex Shi <[email protected]>

> ---
> Documentation/scheduler/sched-design-CFS.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-design-CFS.rst b/Documentation/scheduler/sched-design-CFS.rst
> index 59b2d1fb4dc4..03db55504515 100644
> --- a/Documentation/scheduler/sched-design-CFS.rst
> +++ b/Documentation/scheduler/sched-design-CFS.rst
> @@ -94,7 +94,7 @@ other HZ detail. Thus the CFS scheduler has no notion of "timeslices" in the
> way the previous scheduler had, and has no heuristics whatsoever. There is
> only one central tunable (you have to switch on CONFIG_SCHED_DEBUG):
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> which can be used to tune the scheduler from "desktop" (i.e., low latencies) to
> "server" (i.e., good batching) workloads. It defaults to a setting suitable
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> index 26b0f36f793d..3076402406c4 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> @@ -80,7 +80,7 @@ p->se.vruntime。一旦p->se.vruntime变得足够大,其它的任务将成为
> CFS使用纳秒粒度的计时,不依赖于任何jiffies或HZ的细节。因此CFS并不像之前的调度器那样
> 有“时间片”的概念,也没有任何启发式的设计。唯一可调的参数(你需要打开CONFIG_SCHED_DEBUG)是:
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> 它可以用来将调度器从“桌面”模式(也就是低时延)调节为“服务器”(也就是高批处理)模式。
> 它的默认设置是适合桌面的工作负载。SCHED_BATCH也被CFS调度器模块处理。
> --
> 2.17.1
>

2022-08-24 14:24:42

by Lukasz Luba

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs



On 8/17/22 03:23, YanTeng Si wrote:
>
> 在 2022/8/16 20:19, Lukasz Luba 写道:
>> Add missing update for the documentation bit of some scheduler knob.
>> The knobs have been moved to /debug/sched/ location (with adjusted
>> names).
>>
>> Signed-off-by: Lukasz Luba <[email protected]>
>
> Tested-by: Yanteng Si <[email protected]>
>

Thanks for testing it!

Regards,
Lukasz

>
> CC Yizhou
>
>
> Thanks,
>
> Yanteng
>

2022-08-29 10:11:02

by Lukasz Luba

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs

Hi Jonathan,


On 8/16/22 13:19, Lukasz Luba wrote:
> Add missing update for the documentation bit of some scheduler knob.
> The knobs have been moved to /debug/sched/ location (with adjusted names).
>
> Signed-off-by: Lukasz Luba <[email protected]>
> ---
> Documentation/scheduler/sched-design-CFS.rst | 2 +-
> Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/scheduler/sched-design-CFS.rst b/Documentation/scheduler/sched-design-CFS.rst
> index 59b2d1fb4dc4..03db55504515 100644
> --- a/Documentation/scheduler/sched-design-CFS.rst
> +++ b/Documentation/scheduler/sched-design-CFS.rst
> @@ -94,7 +94,7 @@ other HZ detail. Thus the CFS scheduler has no notion of "timeslices" in the
> way the previous scheduler had, and has no heuristics whatsoever. There is
> only one central tunable (you have to switch on CONFIG_SCHED_DEBUG):
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> which can be used to tune the scheduler from "desktop" (i.e., low latencies) to
> "server" (i.e., good batching) workloads. It defaults to a setting suitable
> diff --git a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> index 26b0f36f793d..3076402406c4 100644
> --- a/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> +++ b/Documentation/translations/zh_CN/scheduler/sched-design-CFS.rst
> @@ -80,7 +80,7 @@ p->se.vruntime。一旦p->se.vruntime变得足够大,其它的任务将成为
> CFS使用纳秒粒度的计时,不依赖于任何jiffies或HZ的细节。因此CFS并不像之前的调度器那样
> 有“时间片”的概念,也没有任何启发式的设计。唯一可调的参数(你需要打开CONFIG_SCHED_DEBUG)是:
>
> - /proc/sys/kernel/sched_min_granularity_ns
> + /sys/kernel/debug/sched/min_granularity_ns
>
> 它可以用来将调度器从“桌面”模式(也就是低时延)调节为“服务器”(也就是高批处理)模式。
> 它的默认设置是适合桌面的工作负载。SCHED_BATCH也被CFS调度器模块处理。


Gentle ping. Could you take this patch, please?

Regards,
Lukasz

2022-08-29 16:50:02

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs

Lukasz Luba <[email protected]> writes:

> Gentle ping. Could you take this patch, please?

I was hoping for an ack from the scheduler folks. It seems correct,
though, so I've applied it.

Thanks,

jon

2022-08-30 11:10:57

by Lukasz Luba

[permalink] [raw]
Subject: Re: [PATCH] docs: scheduler: Update new path for the sysctl knobs



On 8/29/22 17:34, Jonathan Corbet wrote:
> Lukasz Luba <[email protected]> writes:
>
>> Gentle ping. Could you take this patch, please?
>
> I was hoping for an ack from the scheduler folks. It seems correct,
> though, so I've applied it.

Thanks! Yes, it looks like this was just missed during the files
movement in this commit:

8a99b6833c884fa0e79190

Regards,
Lukasz