2022-08-16 13:23:06

by Jilin Yuan

Subject: [PATCH] video/fbdev: fix repeated words in comments

Delete the redundant word 'set'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/video/fbdev/ssd1307fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 5c765655d000..52e4ed9da78c 100644
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -450,7 +450,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
if (ret < 0)
return ret;

- /* Set Set Area Color Mode ON/OFF & Low Power Display Mode */
+ /* Set Area Color Mode ON/OFF & Low Power Display Mode */
if (par->area_color_enable || par->low_power) {
u32 mode;

--
2.36.1

2022-08-24 07:37:30

by Geert Uytterhoeven

Subject: Re: [PATCH] video/fbdev: fix repeated words in comments

Hi Jilin,

On Tue, Aug 16, 2022 at 3:08 PM Jilin Yuan <[email protected]> wrote:
> Delete the redundant word 'set'.
>
> Signed-off-by: Jilin Yuan <[email protected]>

Thanks for your patch, which is now commit 253cabc01468d6b5 ("fbdev:
ssd1307fb: Fix repeated words in comments") in fbdev/for-next

> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -450,7 +450,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
> if (ret < 0)
> return ret;
>
> - /* Set Set Area Color Mode ON/OFF & Low Power Display Mode */
> + /* Set Area Color Mode ON/OFF & Low Power Display Mode */
> if (par->area_color_enable || par->low_power) {
> u32 mode;

Given the register being written below is called
SSD1307FB_SET_AREA_COLOR_MODE, I think the original was correct
(hint: the "S" in "Set" was capitalized).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds