2022-08-17 06:08:13

by Farber, Eliav

Subject: [PATCH v2 02/16] hwmon: (mr75203) update pvt->v_num to the actual number of used sensors

This issue is relevant when intel,vm-map is set, and defines a lower
number of VMs than actually supported.

This change is needed for all places that use pvt->v_num later on in the
code.

Signed-off-by: Eliav Farber <[email protected]>
---
drivers/hwmon/mr75203.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
index 0e29877a1a9c..f89f7bb5d698 100644
--- a/drivers/hwmon/mr75203.c
+++ b/drivers/hwmon/mr75203.c
@@ -605,6 +605,7 @@ static int mr75203_probe(struct platform_device *pdev)
break;

vm_num = i;
+ pvt->v_num = i;
}

in_config = devm_kcalloc(dev, vm_num + 1,
--
2.37.1

2022-08-18 19:53:31

by Guenter Roeck

Subject: Re: [PATCH v2 02/16] hwmon: (mr75203) update pvt->v_num to the actual number of used sensors

On Wed, Aug 17, 2022 at 05:43:07AM +0000, Eliav Farber wrote:
> This issue is relevant when intel,vm-map is set, and defines a lower
> number of VMs than actually supported.
>
> This change is needed for all places that use pvt->v_num later on in the
> code.
>
> Signed-off-by: Eliav Farber <[email protected]>
> ---
> drivers/hwmon/mr75203.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 0e29877a1a9c..f89f7bb5d698 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -605,6 +605,7 @@ static int mr75203_probe(struct platform_device *pdev)
> break;
>
> vm_num = i;
> + pvt->v_num = i;

This code is changed to no longer set pvt->v_num in the previous patch.
Do not send patches which fix issues introduced in an earlier patch of
the same series. Besides, again, regarding "when intel,vm-map is set":
That is not an optional property.

Guenter

> }
>
> in_config = devm_kcalloc(dev, vm_num + 1,