2022-08-17 08:05:14

by Khalid Masum

Subject: [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO

The capabilities enabled for multi-link are required as part of the
programming sequences, even when a stream uses a single link we still
use the syncArm/syncGo sequences. Therefore the TODO is no longer
necessary.

Suggested-by: Pierre-Louis Bossart <[email protected]>
Signed-off-by: Khalid Masum <[email protected]>
---
Previous discussions:
- v2 Link: https://lore.kernel.org/lkml/[email protected]/
- v1 Link: https://lore.kernel.org/lkml/[email protected]/

Changes since v2:
- Update commit title.

Changes since v1:
- Remove the todo, leave rest of the code as is.
- Update commit message.

drivers/soundwire/bus.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 8d4000664fa3..18158825a6d8 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,

/*
* Initialize multi_link flag
- * TODO: populate this flag by reading property from FW node
*/
bus->multi_link = false;
if (bus->ops->read_prop) {
--
2.37.1

2022-08-23 19:32:45

by Vinod Koul

Subject: Re: [PATCH v3 linux-next] soundwire: intel: Remove unnecessary TODO

On 17-08-22, 13:48, Khalid Masum wrote:
> The capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences. Therefore the TODO is no longer
> necessary.

Applied, thanks

--
~Vinod