From: Wei Fang <[email protected]>
Add the fec node on i.MX8ULP platfroms.
And enable the fec support on i.MX8ULP EVK boards.
Wei Fang (3):
dt-bindings: net: fsl,fec: Add i.MX8ULP FEC items
arm64: dts: imx8ulp: Add the fec support
arm64: dts: imx8ulp-evk: Add the fec support
.../devicetree/bindings/net/fsl,fec.yaml | 5 ++
arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 57 +++++++++++++++++++
arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 ++++
3 files changed, 73 insertions(+)
--
2.25.1
From: Wei Fang <[email protected]>
Add the fec support on i.MX8ULP platforms.
Signed-off-by: Wei Fang <[email protected]>
Reviewed-by: Ahmad Fatoum <[email protected]>
---
V2 change:
Remove the external clocks which is related to specific board.
V3 change:
No change.
V4 Change:
Add Reviewed-by tag.
---
arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index 60c1b018bf03..3e8a1e4f0fc2 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -16,6 +16,7 @@ / {
#size-cells = <2>;
aliases {
+ ethernet0 = &fec;
gpio0 = &gpiod;
gpio1 = &gpioe;
gpio2 = &gpiof;
@@ -365,6 +366,16 @@ usdhc2: mmc@298f0000 {
bus-width = <4>;
status = "disabled";
};
+
+ fec: ethernet@29950000 {
+ compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec";
+ reg = <0x29950000 0x10000>;
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "int0";
+ fsl,num-tx-queues = <1>;
+ fsl,num-rx-queues = <1>;
+ status = "disabled";
+ };
};
gpioe: gpio@2d000080 {
--
2.25.1
On Wed, 27 Jul 2022 00:38:50 +1000 [email protected] wrote:
> From: Wei Fang <[email protected]>
>
> Add the fec node on i.MX8ULP platfroms.
> And enable the fec support on i.MX8ULP EVK boards.
FWIW the dts patches do not apply cleanly to netdev so if someone wants
to take the whole thing please LMK/LUK otherwise we can take the schema
in separately for 5.20 and leave the rest to whoever.
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Wed, 27 Jul 2022 00:38:50 +1000 you wrote:
> From: Wei Fang <[email protected]>
>
> Add the fec node on i.MX8ULP platfroms.
> And enable the fec support on i.MX8ULP EVK boards.
>
> Wei Fang (3):
> dt-bindings: net: fsl,fec: Add i.MX8ULP FEC items
> arm64: dts: imx8ulp: Add the fec support
> arm64: dts: imx8ulp-evk: Add the fec support
>
> [...]
Here is the summary with links:
- [V4,1/3] dt-bindings: net: fsl,fec: Add i.MX8ULP FEC items
https://git.kernel.org/netdev/net-next/c/ad3564ccc367
- [V4,2/3] arm64: dts: imx8ulp: Add the fec support
(no matching commit)
- [V4,3/3] arm64: dts: imx8ulp-evk: Add the fec support
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: 2022??8??17?? 17:47
> To: Wei Fang <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> dl-linux-imx <[email protected]>; Peng Fan <[email protected]>; Jacky Bai
> <[email protected]>; [email protected];
> [email protected]; Aisheng Dong <[email protected]>
> Subject: Re: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support
>
> On Wed, Jul 27, 2022 at 12:38:52AM +1000, [email protected] wrote:
> > From: Wei Fang <[email protected]>
> >
> > Add the fec support on i.MX8ULP platforms.
> >
> > Signed-off-by: Wei Fang <[email protected]>
> > Reviewed-by: Ahmad Fatoum <[email protected]>
> > ---
> > V2 change:
> > Remove the external clocks which is related to specific board.
> > V3 change:
> > No change.
> > V4 Change:
> > Add Reviewed-by tag.
> > ---
> > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > index 60c1b018bf03..3e8a1e4f0fc2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -16,6 +16,7 @@ / {
> > #size-cells = <2>;
> >
> > aliases {
> > + ethernet0 = &fec;
> > gpio0 = &gpiod;
> > gpio1 = &gpioe;
> > gpio2 = &gpiof;
> > @@ -365,6 +366,16 @@ usdhc2: mmc@298f0000 {
> > bus-width = <4>;
> > status = "disabled";
> > };
> > +
> > + fec: ethernet@29950000 {
> > + compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec",
> > +"fsl,imx6q-fec";
>
> Since imx8ulp-fec is compatible with imx6ul-fec, what's the point of having
> imx6q-fec in there? It can be dropped, I guess?
>
Actually, I did drop this in version 1. But when I added the imx8ulp compatible
property to the fsl,fec.yaml, the maintainer expected imx8ulp to be compatible
with imx6ul and with imx6q. The patch of fsl,fec.yaml as follows:
--- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
@@ -58,6 +58,11 @@ properties:
- fsl,imx8qxp-fec
- const: fsl,imx8qm-fec
- const: fsl,imx6sx-fec
+ - items:
+ - enum:
+ - fsl,imx8ulp-fec
+ - const: fsl,imx6ul-fec
+ - const: fsl,imx6q-fec
For compliant with the fsl,fec.yaml, so I added the imx6q-fec in the later
version. And the patch of the fsl,fec.yaml has already applied to the
upstream kernel. Therefore, I think it does not matter if the imx6q-fec is
added.
> Shawn
>
> > + reg = <0x29950000 0x10000>;
> > + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "int0";
> > + fsl,num-tx-queues = <1>;
> > + fsl,num-rx-queues = <1>;
> > + status = "disabled";
> > + };
> > };
> >
> > gpioe: gpio@2d000080 {
> > --
> > 2.25.1
> >
On Wed, Jul 27, 2022 at 12:38:52AM +1000, [email protected] wrote:
> From: Wei Fang <[email protected]>
>
> Add the fec support on i.MX8ULP platforms.
>
> Signed-off-by: Wei Fang <[email protected]>
> Reviewed-by: Ahmad Fatoum <[email protected]>
> ---
> V2 change:
> Remove the external clocks which is related to specific board.
> V3 change:
> No change.
> V4 Change:
> Add Reviewed-by tag.
> ---
> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 60c1b018bf03..3e8a1e4f0fc2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -16,6 +16,7 @@ / {
> #size-cells = <2>;
>
> aliases {
> + ethernet0 = &fec;
> gpio0 = &gpiod;
> gpio1 = &gpioe;
> gpio2 = &gpiof;
> @@ -365,6 +366,16 @@ usdhc2: mmc@298f0000 {
> bus-width = <4>;
> status = "disabled";
> };
> +
> + fec: ethernet@29950000 {
> + compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec";
Since imx8ulp-fec is compatible with imx6ul-fec, what's the point of
having imx6q-fec in there? It can be dropped, I guess?
Shawn
> + reg = <0x29950000 0x10000>;
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "int0";
> + fsl,num-tx-queues = <1>;
> + fsl,num-rx-queues = <1>;
> + status = "disabled";
> + };
> };
>
> gpioe: gpio@2d000080 {
> --
> 2.25.1
>
On Wed, Jul 27, 2022 at 12:38:52AM +1000, [email protected] wrote:
> From: Wei Fang <[email protected]>
>
> Add the fec support on i.MX8ULP platforms.
>
> Signed-off-by: Wei Fang <[email protected]>
> Reviewed-by: Ahmad Fatoum <[email protected]>
Applied, thanks!