2022-08-19 01:31:19

by ChenXiaoSong

Subject: [PATCH] mtd: rawnand: remove misguided comment of nand_get_device()

After commit 8cba323437a4 ("mtd: rawnand: protect access to rawnand devices
while in suspend"), it will wait while in suspend rather than returning
errors. So remove the misguided comment about return value.

Signed-off-by: ChenXiaoSong <[email protected]>
---
drivers/mtd/nand/raw/nand_base.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 6b67b7dfe7ce..5e99e4c96da4 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -335,8 +335,6 @@ static int nand_isbad_bbm(struct nand_chip *chip, loff_t ofs)
* @chip: NAND chip structure
*
* Lock the device and its controller for exclusive access
- *
- * Return: -EBUSY if the chip has been suspended, 0 otherwise
*/
static void nand_get_device(struct nand_chip *chip)
{
--
2.31.1

2022-09-20 09:22:24

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: remove misguided comment of nand_get_device()

On Fri, 2022-08-19 at 02:18:46 UTC, ChenXiaoSong wrote:
> After commit 8cba323437a4 ("mtd: rawnand: protect access to rawnand devices
> while in suspend"), it will wait while in suspend rather than returning
> errors. So remove the misguided comment about return value.
>
> Signed-off-by: ChenXiaoSong <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel