2022-08-19 23:19:05

by Jerry Hoemann

Subject: [PATCH 0/2] watchdog/hpwdt: Enable hpwdt for ARM64 platforms

Enable hpwdt for the rl300, an ARM64 based platform.


Jerry Hoemann (2):
watchdog/hpwdt: Build issue for ARM64 platforms
watchdog: Enable HP_WATCHDOG for ARM64 systems.

drivers/watchdog/Kconfig | 4 ++--
drivers/watchdog/hpwdt.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)

--
2.37.1

2022-08-19 23:19:10

by Jerry Hoemann

Subject: [PATCH 2/2] watchdog: Enable HP_WATCHDOG for ARM64 systems.

Enable HP_WATCHDOG for ARM64 systems. HPWDT_NMI_DECODING requires x86.

Signed-off-by: Jerry Hoemann <[email protected]>
---
drivers/watchdog/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 9295492d24f7..cd643e50681e 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1315,7 +1315,7 @@ config IT87_WDT
config HP_WATCHDOG
tristate "HP ProLiant iLO2+ Hardware Watchdog Timer"
select WATCHDOG_CORE
- depends on X86 && PCI
+ depends on (ARM64 || X86) && PCI
help
A software monitoring watchdog and NMI handling driver. This driver
will detect lockups and provide a stack trace. This is a driver that
@@ -1325,7 +1325,7 @@ config HP_WATCHDOG

config HPWDT_NMI_DECODING
bool "NMI support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
- depends on HP_WATCHDOG
+ depends on X86 && HP_WATCHDOG
default y
help
Enables the NMI handler for the watchdog pretimeout NMI and the iLO
--
2.37.1

2022-08-19 23:26:27

by Jerry Hoemann

Subject: [PATCH 1/2] watchdog/hpwdt: Build issue for ARM64 platforms

Fixes commit d48b0e173715 ("x86, nmi, drivers: Fix nmi splitup build bug")

Include <asm/nmi.h> only if CONFIG_HPWDT_NMI_DECODING is defined.

Signed-off-by: Jerry Hoemann <[email protected]>
---
drivers/watchdog/hpwdt.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index a5006a58e0db..f79f932bca14 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -20,7 +20,9 @@
#include <linux/pci_ids.h>
#include <linux/types.h>
#include <linux/watchdog.h>
+#ifdef CONFIG_HPWDT_NMI_DECODING
#include <asm/nmi.h>
+#endif
#include <linux/crash_dump.h>

#define HPWDT_VERSION "2.0.4"
--
2.37.1

2022-08-20 12:07:28

by Guenter Roeck

Subject: Re: [PATCH 1/2] watchdog/hpwdt: Build issue for ARM64 platforms

On Fri, Aug 19, 2022 at 05:14:22PM -0600, Jerry Hoemann wrote:
> Fixes commit d48b0e173715 ("x86, nmi, drivers: Fix nmi splitup build bug")
>
> Include <asm/nmi.h> only if CONFIG_HPWDT_NMI_DECODING is defined.
>
The descrition doesn't describe the problem (what is the build issue ?),
the fix reference should be a Fixes: tag, and the subject should describe
what is done, not the problem (ie "Fix build issue...")

Thanks,
Guenter

> Signed-off-by: Jerry Hoemann <[email protected]>
> ---
> drivers/watchdog/hpwdt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index a5006a58e0db..f79f932bca14 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -20,7 +20,9 @@
> #include <linux/pci_ids.h>
> #include <linux/types.h>
> #include <linux/watchdog.h>
> +#ifdef CONFIG_HPWDT_NMI_DECODING
> #include <asm/nmi.h>
> +#endif
> #include <linux/crash_dump.h>
>
> #define HPWDT_VERSION "2.0.4"
> --
> 2.37.1
>