2022-08-20 08:32:57

by Dario Binacchi

Subject: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4

Add pin configurations for using CAN controller on stm32f469-disco
board. They are located on the Arduino compatible connector CN5 (CAN1)
and on the extension connector CN12 (CAN2).

Signed-off-by: Dario Binacchi <[email protected]>
Signed-off-by: Dario Binacchi <[email protected]>

---

Changes in v2:
- Remove a blank line.

arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 31 ++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 500bcc302d42..3a9c3180fbf9 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -448,6 +448,37 @@ pins2 {
slew-rate = <2>;
};
};
+
+ can1_pins_a: can1-0 {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 9, AF9)>; /* CAN1_TX */
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('B', 8, AF9)>; /* CAN1_RX */
+ bias-pull-up;
+ };
+ };
+
+ can2_pins_a: can2-0 {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('B', 5, AF9)>; /* CAN2_RX */
+ bias-pull-up;
+ };
+ };
+
+ can2_pins_b: can2-1 {
+ pins1 {
+ pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
+ bias-pull-up;
+ };
+ };
+
};
};
};
--
2.32.0

2022-08-23 19:08:03

by Krzysztof Kozlowski

Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4

On 20/08/2022 11:29, Dario Binacchi wrote:
> Add pin configurations for using CAN controller on stm32f469-disco
> board. They are located on the Arduino compatible connector CN5 (CAN1)
> and on the extension connector CN12 (CAN2).
>
> Signed-off-by: Dario Binacchi <[email protected]>
> Signed-off-by: Dario Binacchi <[email protected]>

Do not ignore review. This is not correct. You are mixing copyright with
SoC...

>


> + can2_pins_b: can2-1 {
> + pins1 {
> + pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
> + bias-pull-up;
> + };
> + };
> +

Don't ignore review.

That's second one, so that's a no.. :(

Best regards,
Krzysztof

2022-08-26 06:47:37

by Dario Binacchi

Subject: Re: [RFC PATCH v2 3/4] ARM: dts: stm32: add pin map for CAN controller on stm32f4

Hi Krzysztof,

On Tue, Aug 23, 2022 at 3:43 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 20/08/2022 11:29, Dario Binacchi wrote:
> > Add pin configurations for using CAN controller on stm32f469-disco
> > board. They are located on the Arduino compatible connector CN5 (CAN1)
> > and on the extension connector CN12 (CAN2).
> >
> > Signed-off-by: Dario Binacchi <[email protected]>
> > Signed-off-by: Dario Binacchi <[email protected]>
>
> Do not ignore review. This is not correct. You are mixing copyright with
> SoC...

OK. I got it. I will drop one SOB in version 3.

>
> >
>
>
> > + can2_pins_b: can2-1 {
> > + pins1 {
> > + pinmux = <STM32_PINMUX('B', 13, AF9)>; /* CAN2_TX */
> > + };
> > + pins2 {
> > + pinmux = <STM32_PINMUX('B', 12, AF9)>; /* CAN2_RX */
> > + bias-pull-up;
> > + };
> > + };
> > +
>
> Don't ignore review.

Sorry, I didn't want to ignore your review, I thought the blank line
to be removed was another.
Actually I had to remove two blank lines and I left out the one you suggested.

Thanks and regards,
Dario

>
> That's second one, so that's a no.. :(


>
> Best regards,
> Krzysztof



--

Dario Binacchi

Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

http://www.amarulasolutions.com