Delete the redundant word 'more'.
Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/usb/serial/mct_u232.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
index e3d09a83cab1..f79a1f1b6a98 100644
--- a/drivers/usb/serial/mct_u232.h
+++ b/drivers/usb/serial/mct_u232.h
@@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
* Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
* Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
* Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
- * changed state one more more times since the last time the MSR was
+ * changed state one more times since the last time the MSR was
* read by the host.
* Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
* had a low to high transition since the last time the MSR was read by
* the host.
* Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
- * state one more more times since the last time the MSR was read by the
+ * state one more times since the last time the MSR was read by the
* host.
* Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
* state one more times since the last time the MSR was read by the
--
2.36.1
Hi,
On 21/08/2022 16:34, Jilin Yuan wrote:
> Delete the redundant word 'more'.
>
> Signed-off-by: Jilin Yuan <[email protected]>
> ---
> drivers/usb/serial/mct_u232.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
> index e3d09a83cab1..f79a1f1b6a98 100644
> --- a/drivers/usb/serial/mct_u232.h
> +++ b/drivers/usb/serial/mct_u232.h
> @@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
> * Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
> * Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
> * Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
> - * changed state one more more times since the last time the MSR was
> + * changed state one more times since the last time the MSR was
This does not really make much sense before or after the patch.
Should it read: "one or more times"?
Thanks,
Conor.
> * read by the host.
> * Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
> * had a low to high transition since the last time the MSR was read by
> * the host.
> * Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
> - * state one more more times since the last time the MSR was read by the
> + * state one more times since the last time the MSR was read by the
> * host.
> * Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
> * state one more times since the last time the MSR was read by the
On Mon, Aug 22, 2022 at 07:47:39PM +0800, 无名 wrote:
> Replace 'mode' with 'or'
This is not a proper commit message as it only says what you do, not
why. Try to spell it out.
> Signed-off-by: Jilin Yuan <[email protected]>
> ---
Missing changelog here.
> drivers/usb/serial/mct_u232.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This patch is corrupt and looks like it was sent as HTML too.
Also look at the git log for this file and use the common Subject
prefix.
It's also customary to CC people that have helped review your patch.
Johan