2022-08-22 17:47:32

by Armin Wolf

Subject: [PATCH v2 1/2] hwmon: (dell-smm) Add FW_BUG to SMM warning message

When a SMM call takes very long to execute, then it definitely
is a firmware bug which should be marked with FW_BUG.
Also add the number of the buggy SMM call to the warning message
so BIOS developers, etc immediately know which part of the SMM
interface is buggy.

Tested on a Dell Inspiron 3505.

Signed-off-by: Armin Wolf <[email protected]>
---
drivers/hwmon/dell-smm-hwmon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 7f8d95dd2717..9cac80358072 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -26,6 +26,7 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/platform_device.h>
+#include <linux/printk.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
@@ -198,7 +199,7 @@ static int i8k_smm_func(void *par)
eax, ebx, regs->eax & 0xffff, carry, duration);

if (duration > DELL_SMM_MAX_DURATION)
- pr_warn_once("SMM call took %lld usecs!\n", duration);
+ pr_warn_once(FW_BUG "SMM call 0x%.4x took %lld usecs!\n", eax, duration);

if (carry || (regs->eax & 0xffff) == 0xffff || regs->eax == eax)
return -EINVAL;
--
2.30.2

2022-08-29 14:20:54

by Guenter Roeck

Subject: Re: [PATCH v2 1/2] hwmon: (dell-smm) Add FW_BUG to SMM warning message

On Mon, Aug 22, 2022 at 07:40:52PM +0200, Armin Wolf wrote:
> When a SMM call takes very long to execute, then it definitely
> is a firmware bug which should be marked with FW_BUG.
> Also add the number of the buggy SMM call to the warning message
> so BIOS developers, etc immediately know which part of the SMM
> interface is buggy.
>

I am not going to apply this patch.

It is well known that some of those calls take forever to execute,
and the current limit is just an assumption. This may be a firmware
bug, or it works as expected. We simply don't know, and we can not
declare it to be a firmware bug unless we have confirmation from Dell.

Guenter

> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <[email protected]>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 7f8d95dd2717..9cac80358072 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -26,6 +26,7 @@
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> +#include <linux/printk.h>
> #include <linux/proc_fs.h>
> #include <linux/seq_file.h>
> #include <linux/slab.h>
> @@ -198,7 +199,7 @@ static int i8k_smm_func(void *par)
> eax, ebx, regs->eax & 0xffff, carry, duration);
>
> if (duration > DELL_SMM_MAX_DURATION)
> - pr_warn_once("SMM call took %lld usecs!\n", duration);
> + pr_warn_once(FW_BUG "SMM call 0x%.4x took %lld usecs!\n", eax, duration);
>
> if (carry || (regs->eax & 0xffff) == 0xffff || regs->eax == eax)
> return -EINVAL;