2022-08-24 01:25:59

by Peng Fan (OSS)

[permalink] [raw]
Subject: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP

From: Peng Fan <[email protected]>

V5:
The patchset could not apply on latest remoteproc for-next branch,
so rebased. Only patch 6 has a minor conflict, other patches are not
changed.

V4:
https://lore.kernel.org/all/[email protected]/
Add R-b from DT maintainer
Fix probe failure and driver remove path in patch 3, 4
Add comments about i.MX8QM entries filter in patch 5

V3:
Drop the dependency in V2.
Tested on i.MX8QM/8MM
Use 'fsl,resource-id' and 'fsl,entry-address' Per dt maintainer
Drop 'reg' property Per remoteproc maintainer
Drop mcore self recovery, until we land in common framework support.
https://patchwork.kernel.org/project/linux-remoteproc/cover/[email protected]/

V2:
https://patchwork.kernel.org/project/linux-remoteproc/cover/[email protected]/
Depends on https://patchwork.kernel.org/project/linux-remoteproc/list/?series=621311
Tested on i.MX8QXP/QM/8MP
Addressed Mathieu's comments
Drop V1 patch 5/9, patch 3/9 is replaced with upper dependency patchset
Move V1 patch 4/9 out to https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
Update commit log
Drop magic number to get entry address from device tree in patch 4/6

The V1 patchset:
https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/

Peng Fan (6):
dt-bindings: remoteproc: imx_rproc: support i.MX8QXP
dt-bindings: remoteproc: imx_rproc: support i.MX8QM
remoteproc: imx_rproc: support attaching to i.MX8QXP M4
remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP
remoteproc: imx_rproc: support i.MX8QM
remoteproc: imx_rproc: request mbox channel later

.../bindings/remoteproc/fsl,imx-rproc.yaml | 16 ++
drivers/remoteproc/imx_rproc.c | 261 +++++++++++++++++-
2 files changed, 270 insertions(+), 7 deletions(-)

--
2.37.1


2022-08-24 01:27:44

by Peng Fan (OSS)

[permalink] [raw]
Subject: [PATCH V5 1/6] dt-bindings: remoteproc: imx_rproc: support i.MX8QXP

From: Peng Fan <[email protected]>

Add i.MX8QXP compatible

Add a new property fsl,resource-id for SoC which supports SCFW.
This property is used to check whether remote process is under control
of Linux or not.

Add fsl,entry-address to specify the entry address which used by SCFW
to kick M4.

To i.MX8QM/QXP, when M4 is in the same hardware partition with Cortex-A
cores, need power up M4 through SCFW, then M4 could start. So introduce
power-domains property

Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
.../bindings/remoteproc/fsl,imx-rproc.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
index 3a1f59ad79e2..70322e57b6ff 100644
--- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
@@ -22,6 +22,7 @@ properties:
- fsl,imx8mn-cm7
- fsl,imx8mp-cm7
- fsl,imx8mq-cm4
+ - fsl,imx8qxp-cm4
- fsl,imx8ulp-cm33
- fsl,imx93-cm33

@@ -54,12 +55,26 @@ properties:
minItems: 1
maxItems: 32

+ power-domains:
+ maxItems: 8
+
fsl,auto-boot:
$ref: /schemas/types.yaml#/definitions/flag
description:
Indicate whether need to load the default firmware and start the remote
processor automatically.

+ fsl,entry-address:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Specify CPU entry address for SCU enabled processor.
+
+ fsl,resource-id:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ This property is to specify the resource id of the remote processor in SoC
+ which supports SCFW
+
required:
- compatible

--
2.37.1

2022-09-20 03:38:24

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP

Hi Bjorn, Mathieu

Is this patchset fine for you?
V4 was sent out 2 months ago and no comments,
V5 was sent out near 1 month with only a minor rebase conflict.

Thanks,
Peng.

> Subject: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP
>
> From: Peng Fan <[email protected]>
>
> V5:
> The patchset could not apply on latest remoteproc for-next branch, so
> rebased. Only patch 6 has a minor conflict, other patches are not changed.
>
> V4:
> https://lore.kernel.org/all/20220701104725.557314-1-
> [email protected]/
> Add R-b from DT maintainer
> Fix probe failure and driver remove path in patch 3, 4 Add comments
> about i.MX8QM entries filter in patch 5
>
> V3:
> Drop the dependency in V2.
> Tested on i.MX8QM/8MM
> Use 'fsl,resource-id' and 'fsl,entry-address' Per dt maintainer Drop 'reg'
> property Per remoteproc maintainer Drop mcore self recovery, until we
> land in common framework support.
> https://patchwork.kernel.org/project/linux-
> remoteproc/cover/[email protected]/
>
> V2:
> https://patchwork.kernel.org/project/linux-
> remoteproc/cover/[email protected]/
> Depends on https://patchwork.kernel.org/project/linux-
> remoteproc/list/?series=621311
> Tested on i.MX8QXP/QM/8MP
> Addressed Mathieu's comments
> Drop V1 patch 5/9, patch 3/9 is replaced with upper dependency patchset
> Move V1 patch 4/9 out to https://patchwork.kernel.org/project/linux-
> remoteproc/patch/[email protected]/
> Update commit log
> Drop magic number to get entry address from device tree in patch 4/6
>
> The V1 patchset:
> https://patchwork.kernel.org/project/linux-
> remoteproc/patch/[email protected]/
>
> Peng Fan (6):
> dt-bindings: remoteproc: imx_rproc: support i.MX8QXP
> dt-bindings: remoteproc: imx_rproc: support i.MX8QM
> remoteproc: imx_rproc: support attaching to i.MX8QXP M4
> remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP
> remoteproc: imx_rproc: support i.MX8QM
> remoteproc: imx_rproc: request mbox channel later
>
> .../bindings/remoteproc/fsl,imx-rproc.yaml | 16 ++
> drivers/remoteproc/imx_rproc.c | 261 +++++++++++++++++-
> 2 files changed, 270 insertions(+), 7 deletions(-)
>
> --
> 2.37.1

2022-09-20 07:17:16

by Peng Fan

[permalink] [raw]
Subject: RE: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP

Correct Bjorn's mail address.

> -----Original Message-----
> From: Peng Fan <[email protected]>
> Sent: 2022??9??20?? 11:09
> To: Peng Fan (OSS) <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; dl-linux-imx <linux-
> [email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: RE: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP
>
> Hi Bjorn, Mathieu
>
> Is this patchset fine for you?
> V4 was sent out 2 months ago and no comments,
> V5 was sent out near 1 month with only a minor rebase conflict.
>
> Thanks,
> Peng.

Thanks,
Peng.

>
> > Subject: [PATCH V5 0/6] remoteproc: imx_rproc: support i.MX8QM/QXP
> >
> > From: Peng Fan <[email protected]>
> >
> > V5:
> > The patchset could not apply on latest remoteproc for-next branch,
> > so rebased. Only patch 6 has a minor conflict, other patches are not
> changed.
> >
> > V4:
> > https://lore.kernel.org/all/20220701104725.557314-1-
> > [email protected]/
> > Add R-b from DT maintainer
> > Fix probe failure and driver remove path in patch 3, 4 Add comments
> > about i.MX8QM entries filter in patch 5
> >
> > V3:
> > Drop the dependency in V2.
> > Tested on i.MX8QM/8MM
> > Use 'fsl,resource-id' and 'fsl,entry-address' Per dt maintainer Drop 'reg'
> > property Per remoteproc maintainer Drop mcore self recovery, until we
> > land in common framework support.
> > https://patchwork.kernel.org/project/linux-
> > remoteproc/cover/[email protected]/
> >
> > V2:
> > https://patchwork.kernel.org/project/linux-
> > remoteproc/cover/[email protected]/
> > Depends on https://patchwork.kernel.org/project/linux-
> > remoteproc/list/?series=621311
> > Tested on i.MX8QXP/QM/8MP
> > Addressed Mathieu's comments
> > Drop V1 patch 5/9, patch 3/9 is replaced with upper dependency
> > patchset Move V1 patch 4/9 out to
> > https://patchwork.kernel.org/project/linux-
> > remoteproc/patch/[email protected]/
> > Update commit log
> > Drop magic number to get entry address from device tree in patch 4/6
> >
> > The V1 patchset:
> > https://patchwork.kernel.org/project/linux-
> > remoteproc/patch/[email protected]/
> >
> > Peng Fan (6):
> > dt-bindings: remoteproc: imx_rproc: support i.MX8QXP
> > dt-bindings: remoteproc: imx_rproc: support i.MX8QM
> > remoteproc: imx_rproc: support attaching to i.MX8QXP M4
> > remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP
> > remoteproc: imx_rproc: support i.MX8QM
> > remoteproc: imx_rproc: request mbox channel later
> >
> > .../bindings/remoteproc/fsl,imx-rproc.yaml | 16 ++
> > drivers/remoteproc/imx_rproc.c | 261 +++++++++++++++++-
> > 2 files changed, 270 insertions(+), 7 deletions(-)
> >
> > --
> > 2.37.1