2022-08-24 13:57:28

by Jilin Yuan

Subject: [PATCH] i2c/cx25840: fix repeated words in comments

Delete the redundant word 'of'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/media/i2c/cx25840/cx25840-ir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/cx25840/cx25840-ir.c b/drivers/media/i2c/cx25840/cx25840-ir.c
index 9d7d1d149f1a..8cef9656c612 100644
--- a/drivers/media/i2c/cx25840/cx25840-ir.c
+++ b/drivers/media/i2c/cx25840/cx25840-ir.c
@@ -196,7 +196,7 @@ static u32 clock_divider_to_resolution(u16 divider)
{
/*
* Resolution is the duration of 1 tick of the readable portion of
- * of the pulse width counter as read from the FIFO. The two lsb's are
+ * the pulse width counter as read from the FIFO. The two lsb's are
* not readable, hence the << 2. This function returns ns.
*/
return DIV_ROUND_CLOSEST((1 << 2) * ((u32) divider + 1) * 1000,
--
2.36.1

2022-08-24 15:09:30

by Hans Verkuil

Subject: Re: [PATCH] i2c/cx25840: fix repeated words in comments

This is a duplicate of:

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Please check for similar patches first in the future.

Why is seemingly everyone suddenly chasing errors like this?

I don't mind taking such patches since typos like this annoy me, but
having to figure out which patches are duplicates is getting old quickly...

I'll try to go through your patches and see which are duplicates, but
next time I'd appreciate it if you would check this first.

Regards,

Hans

On 24/08/2022 15:16, Jilin Yuan wrote:
> Delete the redundant word 'of'.
>
> Signed-off-by: Jilin Yuan <[email protected]>
> ---
> drivers/media/i2c/cx25840/cx25840-ir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/cx25840/cx25840-ir.c b/drivers/media/i2c/cx25840/cx25840-ir.c
> index 9d7d1d149f1a..8cef9656c612 100644
> --- a/drivers/media/i2c/cx25840/cx25840-ir.c
> +++ b/drivers/media/i2c/cx25840/cx25840-ir.c
> @@ -196,7 +196,7 @@ static u32 clock_divider_to_resolution(u16 divider)
> {
> /*
> * Resolution is the duration of 1 tick of the readable portion of
> - * of the pulse width counter as read from the FIFO. The two lsb's are
> + * the pulse width counter as read from the FIFO. The two lsb's are
> * not readable, hence the << 2. This function returns ns.
> */
> return DIV_ROUND_CLOSEST((1 << 2) * ((u32) divider + 1) * 1000,