2022-08-25 01:29:41

by Yu Zhe

Subject: [PATCH] mfd: fix tests for platform_get_irq() failure

The platform_get_irq() returns negative error codes. It can't actually
return zero.

Signed-off-by: Yu Zhe <[email protected]>
---
drivers/mfd/fsl-imx25-tsadc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
index 37e5e02a1d05..8ccdfd73e694 100644
--- a/drivers/mfd/fsl-imx25-tsadc.c
+++ b/drivers/mfd/fsl-imx25-tsadc.c
@@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)
struct mx25_tsadc *tsadc = platform_get_drvdata(pdev);
int irq = platform_get_irq(pdev, 0);

- if (irq) {
+ if (irq > 0) {
irq_set_chained_handler_and_data(irq, NULL, NULL);
irq_domain_remove(tsadc->domain);
}
--
2.11.0

2022-09-08 08:31:14

by Lee Jones

Subject: Re: [PATCH] mfd: fix tests for platform_get_irq() failure

On Thu, 25 Aug 2022, Yu Zhe wrote:

> The platform_get_irq() returns negative error codes. It can't actually
> return zero.
>
> Signed-off-by: Yu Zhe <[email protected]>
> ---
> drivers/mfd/fsl-imx25-tsadc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili

> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index 37e5e02a1d05..8ccdfd73e694 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -179,7 +179,7 @@ static int mx25_tsadc_remove(struct platform_device *pdev)
> struct mx25_tsadc *tsadc = platform_get_drvdata(pdev);
> int irq = platform_get_irq(pdev, 0);
>
> - if (irq) {
> + if (irq > 0) {
> irq_set_chained_handler_and_data(irq, NULL, NULL);
> irq_domain_remove(tsadc->domain);
> }

--
Lee Jones [李琼斯]