This patchset is an attempt to fix device trees and resolve binding
warnings for pl022. This requires updation in clock name to keep
alignment with other platforms and spi node properties for integratorap
platform.
warning: 'sspclk' was expected
Above warning got generated after binding patch got accepted from spi
tree.
https://lore.kernel.org/linux-spi/[email protected]/T/#m0301ae2addf60781a956d94c2b192aa26db42074
This patchset is based on
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git,
master
v3:
- Reword commit message for patches 2-4
- No functional change
- Rebase to top
v2:
- Remove alias in ste platform added in v1
- Split patches as per platforms
Kuldeep Singh (4):
ARM: dts: integratorap: Update spi node properties
ARM: dts: realview: Update spi clock-names property
ARM: dts: versatile: Update spi clock-names property
ARM: dts: ste-dbx: Update spi clock-names property
arch/arm/boot/dts/arm-realview-eb.dtsi | 2 +-
arch/arm/boot/dts/arm-realview-pb1176.dts | 2 +-
arch/arm/boot/dts/arm-realview-pb11mp.dts | 2 +-
arch/arm/boot/dts/arm-realview-pbx.dtsi | 2 +-
arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
arch/arm/boot/dts/ste-dbx5x0.dtsi | 12 ++++++------
arch/arm/boot/dts/versatile-ab.dts | 2 +-
7 files changed, 13 insertions(+), 13 deletions(-)
--
2.25.1
As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
Fix it.
Also update ssp node name to enable spi bindings check.
Signed-off-by: Kuldeep Singh <[email protected]>
---
v3:
- Reword commit message
v2:
-Remove ssp alias
arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts
index d47bfb66d069..4c22e4436271 100644
--- a/arch/arm/boot/dts/integratorap-im-pd1.dts
+++ b/arch/arm/boot/dts/integratorap-im-pd1.dts
@@ -178,12 +178,12 @@ uart@200000 {
clock-names = "uartclk", "apb_pclk";
};
- ssp@300000 {
+ spi@300000 {
compatible = "arm,pl022", "arm,primecell";
reg = <0x00300000 0x1000>;
interrupts-extended = <&impd1_vic 3>;
clocks = <&impd1_sspclk>, <&sysclk>;
- clock-names = "spiclk", "apb_pclk";
+ clock-names = "sspclk", "apb_pclk";
};
impd1_gpio0: gpio@400000 {
--
2.25.1
On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
<[email protected]> wrote:
> As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> Fix it.
>
> Also update ssp node name to enable spi bindings check.
>
> Signed-off-by: Kuldeep Singh <[email protected]>
> ---
> v3:
> - Reword commit message
This and patches 2, 3/4 applied to the versatile DTS branch.
Yours,
Linus Walleij
On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <[email protected]> wrote:
>
> On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
> <[email protected]> wrote:
>
> > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> > Fix it.
> >
> > Also update ssp node name to enable spi bindings check.
> >
> > Signed-off-by: Kuldeep Singh <[email protected]>
> > ---
> > v3:
> > - Reword commit message
>
> This and patches 2, 3/4 applied to the versatile DTS branch.
What happened to this?
Rob
> > This and patches 2, 3/4 applied to the versatile DTS branch.
>
> What happened to this?
Thanks Rob for pointing this out, I lost track for these changes.
I just noticed Linus applied ste-dbx change only and skipped others(integrator,
realview, versatile).
These patches fix clock-name as per pl022 binding which causes no harm.
Linus, Any reason to skip others?
Regards
Kuldeep
On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh
<[email protected]> wrote:
>
> > > This and patches 2, 3/4 applied to the versatile DTS branch.
> >
> > What happened to this?
>
> Thanks Rob for pointing this out, I lost track for these changes.
> I just noticed Linus applied ste-dbx change only and skipped others(integrator,
> realview, versatile).
>
> These patches fix clock-name as per pl022 binding which causes no harm.
> Linus, Any reason to skip others?
I just forgot to send them. I'll fix.
Yours,
Linus Walleij
On Wed, Aug 10, 2022 at 9:47 PM Rob Herring <[email protected]> wrote:
> On Thu, Mar 24, 2022 at 4:07 PM Linus Walleij <[email protected]> wrote:
> >
> > On Sat, Mar 12, 2022 at 12:39 PM Kuldeep Singh
> > <[email protected]> wrote:
> >
> > > As per spi pl022 binding, SPI clock name is "sspclk" and not "spiclk".
> > > Fix it.
> > >
> > > Also update ssp node name to enable spi bindings check.
> > >
> > > Signed-off-by: Kuldeep Singh <[email protected]>
> > > ---
> > > v3:
> > > - Reword commit message
> >
> > This and patches 2, 3/4 applied to the versatile DTS branch.
>
> What happened to this?
I forgot to send them upstream this merge window :/
Simple as that.
I'll send them pronto.
Yours,
Linus Walleij
On Thu, Aug 25, 2022 at 12:15:17AM +0200, Linus Walleij wrote:
> On Mon, Aug 15, 2022 at 7:30 PM Kuldeep Singh
> <[email protected]> wrote:
> >
> > > > This and patches 2, 3/4 applied to the versatile DTS branch.
> > >
> > > What happened to this?
> >
> > Thanks Rob for pointing this out, I lost track for these changes.
> > I just noticed Linus applied ste-dbx change only and skipped others(integrator,
> > realview, versatile).
> >
> > These patches fix clock-name as per pl022 binding which causes no harm.
> > Linus, Any reason to skip others?
>
> I just forgot to send them. I'll fix.
Ok np. Thanks!
--
Kuldeep