2022-08-25 07:28:18

by CGEL

Subject: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

From: ye xingchen <[email protected]>

Return the value drm_mode_config_helper_suspend() directly instead of
storing it in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
{
struct mtk_drm_private *private = dev_get_drvdata(dev);
struct drm_device *drm = private->drm;
- int ret;
-
- ret = drm_mode_config_helper_suspend(drm);

- return ret;
+ return drm_mode_config_helper_suspend(drm);
}

static void mtk_drm_sys_complete(struct device *dev)
--
2.25.1

2022-08-25 13:38:56

by Matthias Brugger

Subject: Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

On 25/08/2022 09:23, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
> storing it in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
> {
> struct mtk_drm_private *private = dev_get_drvdata(dev);
> struct drm_device *drm = private->drm;
> - int ret;
> -
> - ret = drm_mode_config_helper_suspend(drm);
>
> - return ret;
> + return drm_mode_config_helper_suspend(drm);
> }
>
> static void mtk_drm_sys_complete(struct device *dev)

2022-08-25 23:58:01

by Chun-Kuang Hu

Subject: Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

Hi, cgel:

<[email protected]> 於 2022年8月25日 週四 下午3:24寫道：
>
> From: ye xingchen <[email protected]>
>
> Return the value drm_mode_config_helper_suspend() directly instead of
> storing it in another redundant variable.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> v1 -> v2
> Add all the mailinglists that get_maintainers.pl give.
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5f02f8d0e4fc..91f58db5915f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
> {
> struct mtk_drm_private *private = dev_get_drvdata(dev);
> struct drm_device *drm = private->drm;
> - int ret;
> -
> - ret = drm_mode_config_helper_suspend(drm);
>
> - return ret;
> + return drm_mode_config_helper_suspend(drm);
> }
>
> static void mtk_drm_sys_complete(struct device *dev)
> --
> 2.25.1