2022-08-25 07:55:39

by CGEL

Subject: [PATCH linux-next] ACPI: EC: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value acpi_ec_write() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/acpi/ec.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index c95e535035a0..9b42628cf21b 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -917,14 +917,10 @@ EXPORT_SYMBOL(ec_read);

int ec_write(u8 addr, u8 val)
{
- int err;
-
if (!first_ec)
return -ENODEV;

- err = acpi_ec_write(first_ec, addr, val);
-
- return err;
+ return acpi_ec_write(first_ec, addr, val);
}
EXPORT_SYMBOL(ec_write);

--
2.25.1

2022-09-03 18:58:14

by Rafael J. Wysocki

Subject: Re: [PATCH linux-next] ACPI: EC: Remove the unneeded result variable

On Thu, Aug 25, 2022 at 9:27 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value acpi_ec_write() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/acpi/ec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index c95e535035a0..9b42628cf21b 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -917,14 +917,10 @@ EXPORT_SYMBOL(ec_read);
>
> int ec_write(u8 addr, u8 val)
> {
> - int err;
> -
> if (!first_ec)
> return -ENODEV;
>
> - err = acpi_ec_write(first_ec, addr, val);
> -
> - return err;
> + return acpi_ec_write(first_ec, addr, val);
> }
> EXPORT_SYMBOL(ec_write);
>
> --

Applied as 6.1 material with some edits in the subject and changelog.

Thanks!